Revert of "win: Set is_clang=true by default over the weekend."
Reason for revert:
The weekend is over; time to end the experiment.
Original description:
> Re-commit "win: Set is_clang=true by default" over the weekend.
>
> This relands https://codereview.chromium.org/2870543003
>
> To figure out unknown problems. If this inconveniences you in any way, please
> do let us know (ideally on crbug.com) – finding annoying things are part of the
> motivation for this change.
>
> If this breaks anything, please revert with prejudice -- but file a bug for
> us about what went wrong. We intend to revert this on Sunday afternoon if it's not
> reverted earlier due to breaking something.
>
> This also switches win_clang to use MSVC as compiler, to make sure things stay
> compilable with both compilers even while this is in.
>
> Known problems:
> * build times without goma are slower (but you can do goma builds with debug
> info, which are faster)
> * incremental linking of webcore.dll doesn't work, so if you work on blink
> on windows links will be slow. If this affects you, please star
> https://crbug.com/717207 and make yourself heard.
>
> This doesn't affect what we ship, which is currently off an PGO builder.
>
> BUG=709690, 82385
>
> Review-Url: https://codereview.chromium.org/2916933002
> Cr-Commit-Position: refs/heads/master@{#476884}
BUG=709690, 82385
TBR=thakis,brettw
Review-Url: https://codereview.chromium.org/2919313002
Cr-Commit-Position: refs/heads/master@{#476921}
Committed: https://chromium.googlesource.com/chromium/src/+/ba2ff9ad0d643a443575c839e56ae9edf7106643
Description was changed from ========== Revert of "win: Set is_clang=true by default" over the weekend. ...
3 years, 6 months ago
(2017-06-04 22:16:15 UTC)
#1
Description was changed from
==========
Revert of "win: Set is_clang=true by default" over the weekend.
Reason for revert:
The weekend is over; time to end the experiment.
Original description:
> Re-commit "win: Set is_clang=true by default" over the weekend.
>
> This relands https://codereview.chromium.org/2870543003
>
> To figure out unknown problems. If this inconveniences you in any way, please
> do let us know (ideally on crbug.com) – finding annoying things are part of
the
> motivation for this change.
>
> If this breaks anything, please revert with prejudice -- but file a bug for
> us about what went wrong. We intend to revert this on Sunday afternoon if it's
not
> reverted earlier due to breaking something.
>
> This also switches win_clang to use MSVC as compiler, to make sure things stay
> compilable with both compilers even while this is in.
>
> Known problems:
> * build times without goma are slower (but you can do goma builds with debug
> info, which are faster)
> * incremental linking of webcore.dll doesn't work, so if you work on blink
> on windows links will be slow. If this affects you, please star
> https://crbug.com/717207 and make yourself heard.
>
> This doesn't affect what we ship, which is currently off an PGO builder.
>
> BUG=709690, 82385
>
> Review-Url: https://codereview.chromium.org/2916933002
> Cr-Commit-Position: refs/heads/master@{#476884}
BUG=709690, 82385
TBR=thakis,brettw
==========
to
==========
Revert of "win: Set is_clang=true by default over the weekend."
Reason for revert:
The weekend is over; time to end the experiment.
Original description:
> Re-commit "win: Set is_clang=true by default" over the weekend.
>
> This relands https://codereview.chromium.org/2870543003
>
> To figure out unknown problems. If this inconveniences you in any way, please
> do let us know (ideally on crbug.com) – finding annoying things are part of
the
> motivation for this change.
>
> If this breaks anything, please revert with prejudice -- but file a bug for
> us about what went wrong. We intend to revert this on Sunday afternoon if it's
not
> reverted earlier due to breaking something.
>
> This also switches win_clang to use MSVC as compiler, to make sure things stay
> compilable with both compilers even while this is in.
>
> Known problems:
> * build times without goma are slower (but you can do goma builds with debug
> info, which are faster)
> * incremental linking of webcore.dll doesn't work, so if you work on blink
> on windows links will be slow. If this affects you, please star
> https://crbug.com/717207 and make yourself heard.
>
> This doesn't affect what we ship, which is currently off an PGO builder.
>
> BUG=709690, 82385
>
> Review-Url: https://codereview.chromium.org/2916933002
> Cr-Commit-Position: refs/heads/master@{#476884}
BUG=709690, 82385
TBR=thakis,brettw
==========
hans
The CQ bit was checked by hans@chromium.org to run a CQ dry run
3 years, 6 months ago
(2017-06-04 22:16:41 UTC)
#2
mac_chromium_rel_ng is failing Upload to test-results [webkit_tests (with patch)] with WARNING:root:Received HTTP status 500 loading ...
3 years, 6 months ago
(2017-06-05 00:51:05 UTC)
#4
mac_chromium_rel_ng is failing
Upload to test-results [webkit_tests (with patch)]
with
WARNING:root:Received HTTP status 500 loading
"https://test-results.appspot.com/testfile/upload".
I'll land manually.
hans
On 2017/06/05 00:51:05, hans wrote: > mac_chromium_rel_ng is failing > Upload to test-results [webkit_tests (with ...
3 years, 6 months ago
(2017-06-05 00:52:52 UTC)
#5
On 2017/06/05 00:51:05, hans wrote:
> mac_chromium_rel_ng is failing
> Upload to test-results [webkit_tests (with patch)]
> with
> WARNING:root:Received HTTP status 500 loading
> "https://test-results.appspot.com/testfile/upload".
>
> I'll land manually.
Oh, maybe that's not a hard error. I'll give it some more time.
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 6 months ago
(2017-06-05 01:02:34 UTC)
#6
On 2017/06/05 00:52:52, hans wrote: > On 2017/06/05 00:51:05, hans wrote: > > mac_chromium_rel_ng is ...
3 years, 6 months ago
(2017-06-05 01:45:58 UTC)
#9
On 2017/06/05 00:52:52, hans wrote:
> On 2017/06/05 00:51:05, hans wrote:
> > mac_chromium_rel_ng is failing
> > Upload to test-results [webkit_tests (with patch)]
> > with
> > WARNING:root:Received HTTP status 500 loading
> > "https://test-results.appspot.com/testfile/upload".
> >
> > I'll land manually.
>
> Oh, maybe that's not a hard error. I'll give it some more time.
Bots look happy now.
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2919313002/1
3 years, 6 months ago
(2017-06-05 01:46:03 UTC)
#10
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1496627141056870, "parent_rev": "4fc92db39612f3016983a68394d225ac0cbecb6b", "commit_rev": "ba2ff9ad0d643a443575c839e56ae9edf7106643"}
3 years, 6 months ago
(2017-06-05 02:02:14 UTC)
#11
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1496627141056870, "parent_rev":
"4fc92db39612f3016983a68394d225ac0cbecb6b", "commit_rev":
"ba2ff9ad0d643a443575c839e56ae9edf7106643"}
commit-bot: I haz the power
Description was changed from ========== Revert of "win: Set is_clang=true by default over the weekend." ...
3 years, 6 months ago
(2017-06-05 02:02:27 UTC)
#12
Message was sent while issue was closed.
Description was changed from
==========
Revert of "win: Set is_clang=true by default over the weekend."
Reason for revert:
The weekend is over; time to end the experiment.
Original description:
> Re-commit "win: Set is_clang=true by default" over the weekend.
>
> This relands https://codereview.chromium.org/2870543003
>
> To figure out unknown problems. If this inconveniences you in any way, please
> do let us know (ideally on crbug.com) – finding annoying things are part of
the
> motivation for this change.
>
> If this breaks anything, please revert with prejudice -- but file a bug for
> us about what went wrong. We intend to revert this on Sunday afternoon if it's
not
> reverted earlier due to breaking something.
>
> This also switches win_clang to use MSVC as compiler, to make sure things stay
> compilable with both compilers even while this is in.
>
> Known problems:
> * build times without goma are slower (but you can do goma builds with debug
> info, which are faster)
> * incremental linking of webcore.dll doesn't work, so if you work on blink
> on windows links will be slow. If this affects you, please star
> https://crbug.com/717207 and make yourself heard.
>
> This doesn't affect what we ship, which is currently off an PGO builder.
>
> BUG=709690, 82385
>
> Review-Url: https://codereview.chromium.org/2916933002
> Cr-Commit-Position: refs/heads/master@{#476884}
BUG=709690, 82385
TBR=thakis,brettw
==========
to
==========
Revert of "win: Set is_clang=true by default over the weekend."
Reason for revert:
The weekend is over; time to end the experiment.
Original description:
> Re-commit "win: Set is_clang=true by default" over the weekend.
>
> This relands https://codereview.chromium.org/2870543003
>
> To figure out unknown problems. If this inconveniences you in any way, please
> do let us know (ideally on crbug.com) – finding annoying things are part of
the
> motivation for this change.
>
> If this breaks anything, please revert with prejudice -- but file a bug for
> us about what went wrong. We intend to revert this on Sunday afternoon if it's
not
> reverted earlier due to breaking something.
>
> This also switches win_clang to use MSVC as compiler, to make sure things stay
> compilable with both compilers even while this is in.
>
> Known problems:
> * build times without goma are slower (but you can do goma builds with debug
> info, which are faster)
> * incremental linking of webcore.dll doesn't work, so if you work on blink
> on windows links will be slow. If this affects you, please star
> https://crbug.com/717207 and make yourself heard.
>
> This doesn't affect what we ship, which is currently off an PGO builder.
>
> BUG=709690, 82385
>
> Review-Url: https://codereview.chromium.org/2916933002
> Cr-Commit-Position: refs/heads/master@{#476884}
BUG=709690, 82385
TBR=thakis,brettw
Review-Url: https://codereview.chromium.org/2919313002
Cr-Commit-Position: refs/heads/master@{#476921}
Committed:
https://chromium.googlesource.com/chromium/src/+/ba2ff9ad0d643a443575c839e56a...
==========
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/ba2ff9ad0d643a443575c839e56ae9edf7106643
3 years, 6 months ago
(2017-06-05 02:02:30 UTC)
#13
Issue 2919313002: Revert of "win: Set is_clang=true by default" over the weekend.
(Closed)
Created 3 years, 6 months ago by hans
Modified 3 years, 6 months ago
Reviewers: brettw
Base URL:
Comments: 0