Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 2919273002: Don't move raw pointers in third_party/WebKit (Closed)

Created:
3 years, 6 months ago by vabr (Chromium)
Modified:
3 years, 6 months ago
Reviewers:
haraken
CC:
chromium-reviews, shans, rjwright, shalamov, blink-reviews-animation_chromium.org, timvolodine, blink-reviews, wanming.lin, darktears, kinuko+watch, Eric Willigers, Mikhail
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't move raw pointers in third_party/WebKit Moving raw pointers does the same job as copying, but is more verbose and also more confusing: e.g., is the supposed pointer meant to be a smart one? This instance was flagged by the tool from https://codereview.chromium.org/2919243002/. BUG=729393 Review-Url: https://codereview.chromium.org/2919273002 Cr-Commit-Position: refs/heads/master@{#476967} Committed: https://chromium.googlesource.com/chromium/src/+/0afe568a073a2394d826c084f1878fd0ef19bd49

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M third_party/WebKit/Source/modules/sensor/Sensor.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
vabr (Chromium)
Hi haraken@, Could you please review this change? Thank you, Vaclav
3 years, 6 months ago (2017-06-04 17:04:01 UTC) #6
haraken
LGTM
3 years, 6 months ago (2017-06-05 00:47:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2919273002/1
3 years, 6 months ago (2017-06-05 10:27:32 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-05 10:31:33 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0afe568a073a2394d826c084f187...

Powered by Google App Engine
This is Rietveld 408576698