Don't move raw pointers in payments

Don't move raw pointers in payments

Moving raw pointers does the same job as copying, but is more verbose and also
more confusing: e.g., is the supposed pointer meant to be a smart one?

This instance was flagged by the tool from
https://codereview.chromium.org/2919243002/.

The raw pointer here actually contains a heap-allocated object, but the
receiving member variable is already a raw pointer, so no automatic deletion
happens currently.

BUG=729393
Review-Url: https://codereview.chromium.org/2919263002
Cr-Commit-Position: refs/heads/master@{#476975}
Committed: https://chromium.googlesource.com/chromium/src/+/fe465afd8324f24de72a35c032da9ede5bb640f3

[vabr (Chromium), 2017-06-04 13:40:23]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-04 13:40:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2017-06-04 13:41:58]

vabr@chromium.org changed reviewers:
+ mathp@chromium.org

[vabr (Chromium), 2017-06-04 13:41:58]

Hi Mathieu,

Could you please review?

Also, could you please confirm, that the passed dialog object is being destroyed
explicitly somewhere? From a quick search I was not able to confirm that (but
removing the std::move does not change the situation).

Cheers,
Vaclav

[commit-bot: I haz the power, 2017-06-04 14:28:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-04 14:28:17]

Dry run: This issue passed the CQ dry run.

[Mathieu, 2017-06-05 13:17:32]

The CQ bit was checked by mathp@chromium.org

[Mathieu, 2017-06-05 13:17:33]

lgtm

Thanks!

https://codereview.chromium.org/2919263002/diff/1/chrome/browser/ui/views/pay...
File chrome/browser/ui/views/payments/test_chrome_payment_request_delegate.cc
(right):

https://codereview.chromium.org/2919263002/diff/1/chrome/browser/ui/views/pay...
chrome/browser/ui/views/payments/test_chrome_payment_request_delegate.cc:25:
dialog_view->ShowDialog();
In the strange world of views, ShowWebModalDialogViews is called with a pointer
(the delegate, or |dialog_view|) that gets deleted when the dialog is closed.
It's the same pattern in non-test code. Thanks

[commit-bot: I haz the power, 2017-06-05 13:17:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-05 13:21:38]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1496668652317780, "parent_rev":
"52148d9dec33be3f66dc01010b8309bcb247e64c", "commit_rev":
"fe465afd8324f24de72a35c032da9ede5bb640f3"}

[commit-bot: I haz the power, 2017-06-05 13:21:49]

Description was changed from

==========
Don't move raw pointers in payments

Moving raw pointers does the same job as copying, but is more verbose and also
more confusing: e.g., is the supposed pointer meant to be a smart one?

This instance was flagged by the tool from
https://codereview.chromium.org/2919243002/.

The raw pointer here actually contains a heap-allocated object, but the
receiving member variable is already a raw pointer, so no automatic deletion
happens currently.

BUG=729393
==========

to

==========
Don't move raw pointers in payments

Moving raw pointers does the same job as copying, but is more verbose and also
more confusing: e.g., is the supposed pointer meant to be a smart one?

This instance was flagged by the tool from
https://codereview.chromium.org/2919243002/.

The raw pointer here actually contains a heap-allocated object, but the
receiving member variable is already a raw pointer, so no automatic deletion
happens currently.

BUG=729393

Review-Url: https://codereview.chromium.org/2919263002
Cr-Commit-Position: refs/heads/master@{#476975}
Committed:
https://chromium.googlesource.com/chromium/src/+/fe465afd8324f24de72a35c032da...
==========

[commit-bot: I haz the power, 2017-06-05 13:21:50]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fe465afd8324f24de72a35c032da...