Don't move raw pointers in services

Don't move raw pointers in services

Moving raw pointers does the same job as copying, but is more verbose and also
more confusing: e.g., is the supposed pointer meant to be a smart one?

This instance was flagged by the tool from
https://codereview.chromium.org/2919243002/.

BUG=729393
Review-Url: https://codereview.chromium.org/2919253002
Cr-Commit-Position: refs/heads/master@{#477365}
Committed: https://chromium.googlesource.com/chromium/src/+/beebf2b8c6344ff92cbb1e7079a75da479a7a9cd

[vabr (Chromium), 2017-06-04 11:13:57]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-04 11:13:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vabr (Chromium), 2017-06-04 12:32:16]

vabr@chromium.org changed reviewers:
+ bauerb@chromium.org, emircan@chromium.org, erg@chromium.org

[vabr (Chromium), 2017-06-04 12:32:17]

Hi all,

Could you please review as follows?

bauerb@: services/preferences/tracked/pref_hash_store_impl.cc

erg@: services/ui/public/cpp/bitmap/child_shared_bitmap_manager.cc

emircan@: services/video_capture/test/mock_device_factory.cc

Thanks!
Vaclav

[commit-bot: I haz the power, 2017-06-04 13:07:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-04 13:07:42]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2017-06-05 10:10:13]

LGTM, thanks!

[emircan, 2017-06-05 19:06:05]

lgtm

[Elliot Glaysher, 2017-06-06 18:00:14]

lgtm

[vabr (Chromium), 2017-06-06 18:01:58]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2017-06-06 18:02:17]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 19:17:25]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1496772118190230, "parent_rev":
"bc29797ee3f133d33e0505901ceaee0202b2c1ad", "commit_rev":
"beebf2b8c6344ff92cbb1e7079a75da479a7a9cd"}

[commit-bot: I haz the power, 2017-06-06 19:17:38]

Description was changed from

==========
Don't move raw pointers in services

Moving raw pointers does the same job as copying, but is more verbose and also
more confusing: e.g., is the supposed pointer meant to be a smart one?

This instance was flagged by the tool from
https://codereview.chromium.org/2919243002/.

BUG=729393
==========

to

==========
Don't move raw pointers in services

Moving raw pointers does the same job as copying, but is more verbose and also
more confusing: e.g., is the supposed pointer meant to be a smart one?

This instance was flagged by the tool from
https://codereview.chromium.org/2919243002/.

BUG=729393

Review-Url: https://codereview.chromium.org/2919253002
Cr-Commit-Position: refs/heads/master@{#477365}
Committed:
https://chromium.googlesource.com/chromium/src/+/beebf2b8c6344ff92cbb1e7079a7...
==========

[commit-bot: I haz the power, 2017-06-06 19:17:40]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/beebf2b8c6344ff92cbb1e7079a7...