[Cleanup] Remove the obsolete variations_seed pref.

[Cleanup] Remove the obsolete variations_seed pref.

This pref has been replaced by the variations_compressed_seed pref.

BUG=none
TEST=none
R=asvitkine@chromium.org

Review-Url: https://codereview.chromium.org/2919223002
Cr-Commit-Position: refs/heads/master@{#477457}
Committed: https://chromium.googlesource.com/chromium/src/+/9bb3bafb3347ac26c6dbbf78f9b77198f71eb8d5

[Ilya Sherman, 2017-06-04 03:28:54]

The CQ bit was checked by isherman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-04 03:28:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ilya Sherman, 2017-06-04 03:34:45]

The CQ bit was checked by isherman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-04 03:35:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-04 03:46:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-04 03:46:21]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ilya Sherman, 2017-06-04 04:14:38]

The CQ bit was checked by isherman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-04 04:14:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-04 05:43:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-04 05:43:49]

Dry run: This issue passed the CQ dry run.

[Alexei Svitkine (slow), 2017-06-05 14:13:20]

The CQ bit was checked by asvitkine@chromium.org

[Alexei Svitkine (slow), 2017-06-05 14:13:21]

lgtm

Thanks!

[commit-bot: I haz the power, 2017-06-05 14:13:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-05 14:21:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-05 14:21:24]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Ilya Sherman, 2017-06-05 23:30:02]

isherman@chromium.org changed reviewers:
+ gab@chromium.org, sky@chromium.org

[Ilya Sherman, 2017-06-05 23:30:03]

+Gab for all first_run and installer changes.
+Scott for chrome_browser_main.cc

[sky, 2017-06-05 23:59:20]

LGTM

[gab, 2017-06-06 14:45:03]

lgtm w/ question about cleanup phase

https://codereview.chromium.org/2919223002/diff/40001/components/variations/v...
File components/variations/variations_seed_store.cc (left):

https://codereview.chromium.org/2919223002/diff/40001/components/variations/v...
components/variations/variations_seed_store.cc:460:
local_state_->ClearPref(prefs::kVariationsSeed);
Since this pref was passed through master_prefs and manually copied in Local
State I'd expect it to also be found in Preferences for the Default profile as
all master_preferences are copied to Preferences on first run (or am I not
seeing code that was stripping it from master_prefs before that copy?)

[Ilya Sherman, 2017-06-06 20:22:16]

https://codereview.chromium.org/2919223002/diff/40001/components/variations/v...
File components/variations/variations_seed_store.cc (left):

https://codereview.chromium.org/2919223002/diff/40001/components/variations/v...
components/variations/variations_seed_store.cc:460:
local_state_->ClearPref(prefs::kVariationsSeed);
On 2017/06/06 14:45:03, gab wrote:
> Since this pref was passed through master_prefs and manually copied in Local
> State I'd expect it to also be found in Preferences for the Default profile as
> all master_preferences are copied to Preferences on first run (or am I not
> seeing code that was stripping it from master_prefs before that copy?)

Hmm, that sounds like a bug if this and the other related prefs aren't being
stripped -- the prefs should never be read from anywhere other than Local State.
 I'm not sure how to test with master_prefs -- is there documentation for it
someswhere?

[Ilya Sherman, 2017-06-06 21:54:37]

https://codereview.chromium.org/2919223002/diff/40001/components/variations/v...
File components/variations/variations_seed_store.cc (left):

https://codereview.chromium.org/2919223002/diff/40001/components/variations/v...
components/variations/variations_seed_store.cc:460:
local_state_->ClearPref(prefs::kVariationsSeed);
On 2017/06/06 20:22:16, Ilya Sherman wrote:
> On 2017/06/06 14:45:03, gab wrote:
> > Since this pref was passed through master_prefs and manually copied in Local
> > State I'd expect it to also be found in Preferences for the Default profile
as
> > all master_preferences are copied to Preferences on first run (or am I not
> > seeing code that was stripping it from master_prefs before that copy?)
> 
> Hmm, that sounds like a bug if this and the other related prefs aren't being
> stripped -- the prefs should never be read from anywhere other than Local
State.
>  I'm not sure how to test with master_prefs -- is there documentation for it
> someswhere?

Okay, found the docs [1] and then updated them for Mac based on the code [2]. 
You're right, all of the variations_* prefs are being copied into the Default
profile.  I filed https://crbug.com/730204

[1]
https://sites.google.com/a/chromium.org/dev/administrators/configuring-other-...
[2]
https://cs.chromium.org/chromium/src/chrome/browser/mac/master_prefs.mm?q=chr...

[Ilya Sherman, 2017-06-06 21:54:43]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2017-06-06 21:55:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-06 23:15:44]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496786083509880,
"parent_rev": "22f6d5b3389c0b066ae841d12889373818cabfc0", "commit_rev":
"9bb3bafb3347ac26c6dbbf78f9b77198f71eb8d5"}

[commit-bot: I haz the power, 2017-06-06 23:15:57]

Description was changed from

==========
[Cleanup] Remove the obsolete variations_seed pref.

This pref has been replaced by the variations_compressed_seed pref.

BUG=none
TEST=none
R=asvitkine@chromium.org
==========

to

==========
[Cleanup] Remove the obsolete variations_seed pref.

This pref has been replaced by the variations_compressed_seed pref.

BUG=none
TEST=none
R=asvitkine@chromium.org

Review-Url: https://codereview.chromium.org/2919223002
Cr-Commit-Position: refs/heads/master@{#477457}
Committed:
https://chromium.googlesource.com/chromium/src/+/9bb3bafb3347ac26c6dbbf78f9b7...
==========

[commit-bot: I haz the power, 2017-06-06 23:15:59]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9bb3bafb3347ac26c6dbbf78f9b7...