Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 2919183002: Cloning a ui::Layer should also clone its target temperature (Closed)

Created:
3 years, 6 months ago by afakhry
Modified:
3 years, 6 months ago
Reviewers:
piman
CC:
chromium-reviews, Ian Vollick, jbauman+watch_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org, cc-bugs_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Cloning a ui::Layer should also clone its target temperature BUG=729203 TEST=compositor_unittests --gtest_filter=LayerWithDelegateTest.Cloning Review-Url: https://codereview.chromium.org/2919183002 Cr-Commit-Position: refs/heads/master@{#477030} Committed: https://chromium.googlesource.com/chromium/src/+/7cd6f641ac975f67191db0297f34c227de70ae2f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M ui/compositor/layer.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/compositor/layer.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M ui/compositor/layer_unittest.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (15 generated)
afakhry
danakj@ Can you please take a look? Thank you!
3 years, 6 months ago (2017-06-02 23:53:40 UTC) #2
afakhry
dana is OOO. piman@ can you please take a look? Thanks!
3 years, 6 months ago (2017-06-05 16:59:14 UTC) #12
piman
lgtm
3 years, 6 months ago (2017-06-05 18:02:16 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2919183002/1
3 years, 6 months ago (2017-06-05 18:05:10 UTC) #17
commit-bot: I haz the power
3 years, 6 months ago (2017-06-05 18:10:03 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7cd6f641ac975f67191db0297f34...

Powered by Google App Engine
This is Rietveld 408576698