Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2919143002: Fix variations crashes when the chosen trial group is not in study. (Closed)

Created:
3 years, 6 months ago by Alexei Svitkine (slow)
Modified:
3 years, 6 months ago
Reviewers:
jwd
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix variations crashes when the chosen trial group is not in study. Adds a couple tests that would hit that code path. BUG=724957 Review-Url: https://codereview.chromium.org/2919143002 Cr-Commit-Position: refs/heads/master@{#476856} Committed: https://chromium.googlesource.com/chromium/src/+/3cac35f9fdcde39a17ac119d9190139b90f0b75a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -10 lines) Patch
M components/variations/variations_seed_processor.cc View 2 chunks +12 lines, -10 lines 0 comments Download
M components/variations/variations_seed_processor_unittest.cc View 1 chunk +54 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Alexei Svitkine (slow)
3 years, 6 months ago (2017-06-02 20:37:00 UTC) #2
jwd
lgtm
3 years, 6 months ago (2017-06-02 20:56:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2919143002/1
3 years, 6 months ago (2017-06-02 21:03:52 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/309788)
3 years, 6 months ago (2017-06-03 00:20:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2919143002/1
3 years, 6 months ago (2017-06-03 00:28:42 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-03 02:02:41 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3cac35f9fdcde39a17ac119d9190...

Powered by Google App Engine
This is Rietveld 408576698