Fix profile resetter Omaha request:

Fix profile resetter Omaha request:

 • Remove incorrect and unnecessary information.
 • Add disambiguation information as to the sender of the request.

BUG=729150
Review-Url: https://codereview.chromium.org/2919133002
Cr-Commit-Position: refs/heads/master@{#477777}
Committed: https://chromium.googlesource.com/chromium/src/+/099abd0e2c518b41ee8ec40d264a8c27bba0c35a

[waffles, 2017-06-02 20:23:44]

waffles@chromium.org changed reviewers:
+ engedy@chromium.org

[waffles, 2017-06-02 20:23:45]

PTAL, thank you!

[waffles, 2017-06-02 20:23:57]

The CQ bit was checked by waffles@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 20:24:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 21:19:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 21:19:48]

Dry run: This issue passed the CQ dry run.

[engedy, 2017-06-03 08:02:49]

LGTM % nit and requests. Thank you for working on this!

Could you please also verify that the mock response in
profile_resetter_unittest.cc:95 is correct?

Finally, did you already verify end-to-end that the new payload is working as
intended? If not, I can do that next week.

https://codereview.chromium.org/2919133002/diff/1/chrome/browser/profile_rese...
File chrome/browser/profile_resetter/brandcode_config_fetcher.cc (right):

https://codereview.chromium.org/2919133002/diff/1/chrome/browser/profile_rese...
chrome/browser/profile_resetter/brandcode_config_fetcher.cc:8: #include <string>
nit: Looks like <string> should already be included in the corresponding header.
Could you please move this include there?

[waffles, 2017-06-07 17:22:25]

> Finally, did you already verify end-to-end that the new payload is working as
> intended? If not, I can do that next week.
I only verified that the request sent here gets the expected response (using
curl and LENP for brand code) - I didn't end-to-end test this particular code.

> Could you please also verify that the mock response in
> profile_resetter_unittest.cc:95 is correct?
Mock response looks good to me.

[waffles, 2017-06-07 17:23:13]

https://codereview.chromium.org/2919133002/diff/1/chrome/browser/profile_rese...
File chrome/browser/profile_resetter/brandcode_config_fetcher.cc (right):

https://codereview.chromium.org/2919133002/diff/1/chrome/browser/profile_rese...
chrome/browser/profile_resetter/brandcode_config_fetcher.cc:8: #include <string>
On 2017/06/03 08:02:49, engedy wrote:
> nit: Looks like <string> should already be included in the corresponding
header.
> Could you please move this include there? 

Done.

[engedy, 2017-06-07 19:40:38]

Still LGTM, thanks!

[waffles, 2017-06-07 19:55:50]

The CQ bit was checked by waffles@chromium.org

[commit-bot: I haz the power, 2017-06-07 19:56:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 21:12:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-07 21:13:01]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[waffles, 2017-06-07 21:43:47]

The CQ bit was checked by waffles@chromium.org

[commit-bot: I haz the power, 2017-06-07 21:44:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-07 23:25:18]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496871827743510,
"parent_rev": "afa8fdf6a6a9e89cbf0e46d951d28a01c3004793", "commit_rev":
"099abd0e2c518b41ee8ec40d264a8c27bba0c35a"}

[commit-bot: I haz the power, 2017-06-07 23:25:33]

Description was changed from

==========
Fix profile resetter Omaha request:

 • Remove incorrect and unnecessary information.
 • Add disambiguation information as to the sender of the request.

BUG=729150
==========

to

==========
Fix profile resetter Omaha request:

 • Remove incorrect and unnecessary information.
 • Add disambiguation information as to the sender of the request.

BUG=729150

Review-Url: https://codereview.chromium.org/2919133002
Cr-Commit-Position: refs/heads/master@{#477777}
Committed:
https://chromium.googlesource.com/chromium/src/+/099abd0e2c518b41ee8ec40d264a...
==========

[commit-bot: I haz the power, 2017-06-07 23:25:34]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/099abd0e2c518b41ee8ec40d264a...