Issue 291913004: formalize named picture versions

Issue 291913004: formalize named picture versions (Closed)

Created:
6 years, 7 months ago by reed1

Modified:
6 years, 7 months ago

Reviewers:
mtklein, robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

formalize named picture versions BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14807

Patch Set 2 : #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -22 lines)			Patch
M	include/core/SkReadBuffer.h	View	1	3 chunks	+18 lines, -7 lines	0 comments	Download
M	src/core/SkPaint.cpp	View	1	2 chunks	+1 line, -3 lines	0 comments	Download
M	src/core/SkPicturePlayback.cpp	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/core/SkReadBuffer.cpp	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/core/SkShader.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/effects/SkDashPathEffect.cpp	View	1	3 chunks	+1 line, -3 lines	0 comments	Download
M	src/effects/gradients/SkTwoPointConicalGradient.cpp	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

robertphillips

lgtm + nits https://codereview.chromium.org/291913004/diff/1/include/core/SkReadBuffer.h File include/core/SkReadBuffer.h (right): https://codereview.chromium.org/291913004/diff/1/include/core/SkReadBuffer.h#newcode42 include/core/SkReadBuffer.h:42: Remove these two lines? https://codereview.chromium.org/291913004/diff/1/include/core/SkReadBuffer.h#newcode45 include/core/SkReadBuffer.h:45: ...

6 years, 7 months ago (2014-05-20 12:34:05 UTC) #2

reed1

https://codereview.chromium.org/291913004/diff/1/include/core/SkReadBuffer.h File include/core/SkReadBuffer.h (right): https://codereview.chromium.org/291913004/diff/1/include/core/SkReadBuffer.h#newcode42 include/core/SkReadBuffer.h:42: On 2014/05/20 12:34:06, robertphillips wrote: > Remove these two ...

6 years, 7 months ago (2014-05-20 17:21:56 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/291913004/20001

6 years, 7 months ago (2014-05-20 17:22:13 UTC) #5

Message was sent while issue was closed.

Change committed as 14807

Expand Messages | Collapse Messages