Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 291913003: Remove the --locale_pak flag. (Closed)

Created:
6 years, 7 months ago by tony
Modified:
6 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

Remove the --locale_pak flag. This only existed for pseudo locale testing of bidi. I don't think anyone is actively testing this config, so remove it. If needed for manual testing, we could probably come up with a way that doesn't involve a flag (e.g., special way to build the pak file). BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271526

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -14 lines) Patch
M ui/base/resource/resource_bundle.cc View 1 chunk +2 lines, -9 lines 0 comments Download
M ui/base/ui_base_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/base/ui_base_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
tony
6 years, 7 months ago (2014-05-19 17:37:36 UTC) #1
sky
LGTM
6 years, 7 months ago (2014-05-19 18:01:06 UTC) #2
tony
The CQ bit was checked by tony@chromium.org
6 years, 7 months ago (2014-05-19 19:21:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tony@chromium.org/291913003/1
6 years, 7 months ago (2014-05-19 19:22:35 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-19 20:43:19 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-19 21:58:37 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/28547)
6 years, 7 months ago (2014-05-19 21:58:38 UTC) #7
tony
The CQ bit was checked by tony@chromium.org
6 years, 7 months ago (2014-05-19 23:29:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tony@chromium.org/291913003/1
6 years, 7 months ago (2014-05-19 23:30:39 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 01:06:43 UTC) #10
Message was sent while issue was closed.
Change committed as 271526

Powered by Google App Engine
This is Rietveld 408576698