[TTS] Fix crash calling KitKat+ API without check.

[TTS] Fix crash calling KitKat+ API without check.

Adds a check that we're running on KitKat or later before calling
the new API call Character.isIdeographic.

BUG=729096
Review-Url: https://codereview.chromium.org/2919113002
Cr-Commit-Position: refs/heads/master@{#476864}
Committed: https://chromium.googlesource.com/chromium/src/+/cd4a66f23632d80f36aeb301d118a33360681e8b

[Donn Denman, 2017-06-02 21:32:54]

donnd@chromium.org changed reviewers:
+ twellington@chromium.org

[Donn Denman, 2017-06-02 21:32:55]

Theresa, PTAL and this small crash fix (maybe on the bus).  Thanks!

[Theresa, 2017-06-02 21:51:42]

https://codereview.chromium.org/2919113002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchContext.java
(right):

https://codereview.chromium.org/2919113002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchContext.java:279:
private int findWordStartOffset(String text, int initial) {
This is just used to generate a ranker signal for whether the user tapped on the
edge of a word the middle, right?

[Donn Denman, 2017-06-02 22:00:42]

https://codereview.chromium.org/2919113002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchContext.java
(right):

https://codereview.chromium.org/2919113002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchContext.java:279:
private int findWordStartOffset(String text, int initial) {
On 2017/06/02 21:51:42, Theresa wrote:
> This is just used to generate a ranker signal for whether the user tapped on
the
> edge of a word the middle, right?

Correct, so it's non-critical for the feature.

[Theresa, 2017-06-02 22:03:38]

The CQ bit was checked by twellington@chromium.org

[Theresa, 2017-06-02 22:03:38]

lgtm

[commit-bot: I haz the power, 2017-06-02 22:04:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-03 02:23:02]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1496441018198330, "parent_rev":
"e4cbc43409cdddb63d97beb203a497bad5a17d00", "commit_rev":
"841faf4226aa624c14a6864fdc8b4e35bddd6c11"}

[commit-bot: I haz the power, 2017-06-03 02:23:14]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1496441018198330, "parent_rev":
"ea0d919e615ab0c864ba5331c91e640dde5a946f", "commit_rev":
"490c245caff4e922822694765b9749b2eb684ad9"}

[commit-bot: I haz the power, 2017-06-03 02:23:30]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1496441018198330, "parent_rev":
"3feac254e12fbf35cde146ab9693110b5713d4e6", "commit_rev":
"cd4a66f23632d80f36aeb301d118a33360681e8b"}

[commit-bot: I haz the power, 2017-06-03 02:23:38]

Description was changed from

==========
[TTS] Fix crash calling KitKat+ API without check.

Adds a check that we're running on KitKat or later before calling
the new API call Character.isIdeographic.

BUG=729096
==========

to

==========
[TTS] Fix crash calling KitKat+ API without check.

Adds a check that we're running on KitKat or later before calling
the new API call Character.isIdeographic.

BUG=729096

Review-Url: https://codereview.chromium.org/2919113002
Cr-Commit-Position: refs/heads/master@{#476864}
Committed:
https://chromium.googlesource.com/chromium/src/+/cd4a66f23632d80f36aeb301d118...
==========

[commit-bot: I haz the power, 2017-06-03 02:23:39]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cd4a66f23632d80f36aeb301d118...