Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2919063002: [modules] Teach JSObject::ReferencesObject about module contexts. (Closed)

Created:
3 years, 6 months ago by neis
Modified:
3 years, 6 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[modules] Teach JSObject::ReferencesObject about module contexts. A module context holds the module object in its extension slot, which should not be recursed on (it's not even a JSObject). (I don't know how this code path can be triggered, though.) R=adamk@chromium.org BUG=v8:1569 Review-Url: https://codereview.chromium.org/2919063002 Cr-Commit-Position: refs/heads/master@{#45695} Committed: https://chromium.googlesource.com/v8/v8/+/90b68baabc5ba545de2a73047f9beaac8b5bc0b5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/objects.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
neis
3 years, 6 months ago (2017-06-02 13:05:12 UTC) #1
adamk
lgtm
3 years, 6 months ago (2017-06-02 17:06:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2919063002/1
3 years, 6 months ago (2017-06-02 17:34:19 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 17:36:09 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/90b68baabc5ba545de2a73047f9beaac8b5...

Powered by Google App Engine
This is Rietveld 408576698