[heap] Scale max heap growing factor.

[heap] Scale max heap growing factor.

BUG=chromium:716032
Review-Url: https://codereview.chromium.org/2919023003
Cr-Commit-Position: refs/heads/master@{#45850}
Committed: https://chromium.googlesource.com/v8/v8/+/07b7d7206ac49997077bdff37e42fec71e492149

[Hannes Payer (out of office), 2017-06-08 16:17:16]

The CQ bit was checked by hpayer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 16:17:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 16:44:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-08 16:44:09]

Dry run: This issue passed the CQ dry run.

[Hannes Payer (out of office), 2017-06-08 16:54:49]

The CQ bit was checked by hpayer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-08 16:55:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-08 17:22:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-08 17:22:32]

Dry run: This issue passed the CQ dry run.

[Hannes Payer (out of office), 2017-06-09 06:21:00]

hpayer@chromium.org changed reviewers:
+ ulan@chromium.org

[ulan, 2017-06-09 08:39:43]

lgtm

https://codereview.chromium.org/2919023003/diff/80001/src/heap/heap.cc
File src/heap/heap.cc (right):

https://codereview.chromium.org/2919023003/diff/80001/src/heap/heap.cc#newcod...
src/heap/heap.cc:5465: if (max_old_generation_size_in_mb ==
kMaxOldGenerationSize) {
Should it be >= instead of == ?

https://codereview.chromium.org/2919023003/diff/80001/src/heap/heap.cc#newcod...
src/heap/heap.cc:5475: (kMaxOldGenerationSize - 1 - kMinOldGenerationSize) +
Why (-1) here?

[Hannes Payer (out of office), 2017-06-09 12:16:47]

https://codereview.chromium.org/2919023003/diff/80001/src/heap/heap.cc
File src/heap/heap.cc (right):

https://codereview.chromium.org/2919023003/diff/80001/src/heap/heap.cc#newcod...
src/heap/heap.cc:5465: if (max_old_generation_size_in_mb ==
kMaxOldGenerationSize) {
On 2017/06/09 08:39:43, ulan wrote:
> Should it be >= instead of == ?

Done.

https://codereview.chromium.org/2919023003/diff/80001/src/heap/heap.cc#newcod...
src/heap/heap.cc:5475: (kMaxOldGenerationSize - 1 - kMinOldGenerationSize) +
On 2017/06/09 08:39:43, ulan wrote:
> Why (-1) here?

I decided to do that because we would never reach the 2.0 case otherwise. For
simplicity, I am happy to remove it.

[Hannes Payer (out of office), 2017-06-09 12:16:50]

The CQ bit was checked by hpayer@chromium.org

[Hannes Payer (out of office), 2017-06-09 12:16:51]

The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org
Link to the patchset: https://codereview.chromium.org/2919023003/#ps100001
(title: "comments")

[commit-bot: I haz the power, 2017-06-09 12:16:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-09 12:36:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-09 12:36:05]

Try jobs failed on following builders:
  v8_linux_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_verify_csa_rel_ng/...)
  v8_linux_verify_csa_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_verify_csa_rel_ng_...)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/23741)
  v8_mac_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/bui...)

[Hannes Payer (out of office), 2017-06-09 12:59:15]

The CQ bit was checked by hpayer@chromium.org

[Hannes Payer (out of office), 2017-06-09 12:59:16]

The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org
Link to the patchset: https://codereview.chromium.org/2919023003/#ps120001
(title: "format")

[commit-bot: I haz the power, 2017-06-09 12:59:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-09 13:16:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-09 13:16:23]

Try jobs failed on following builders:
  v8_linux64_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_verify_csa_rel_n...)
  v8_linux64_verify_csa_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_verify_csa_rel_n...)

[Hannes Payer (out of office), 2017-06-12 11:05:51]

The CQ bit was checked by hpayer@chromium.org

[Hannes Payer (out of office), 2017-06-12 11:05:51]

The patchset sent to the CQ was uploaded after l-g-t-m from ulan@chromium.org
Link to the patchset: https://codereview.chromium.org/2919023003/#ps140001
(title: "tests")

[commit-bot: I haz the power, 2017-06-12 11:05:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-12 11:37:16]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1497265551652090,
"parent_rev": "f555a6922dd1b425ed845370cd01428b3ba46f93", "commit_rev":
"07b7d7206ac49997077bdff37e42fec71e492149"}

[commit-bot: I haz the power, 2017-06-12 11:37:22]

Description was changed from

==========
[heap] Scale max heap growing factor.

BUG=chromium:716032
==========

to

==========
[heap] Scale max heap growing factor.

BUG=chromium:716032

Review-Url: https://codereview.chromium.org/2919023003
Cr-Commit-Position: refs/heads/master@{#45850}
Committed:
https://chromium.googlesource.com/v8/v8/+/07b7d7206ac49997077bdff37e42fec71e4...
==========

[commit-bot: I haz the power, 2017-06-12 11:37:23]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/v8/v8/+/07b7d7206ac49997077bdff37e42fec71e4...