Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2919023002: Do not dismiss the Save Password Infobar when a redirection occurs. (Closed)

Created:
3 years, 6 months ago by jif
Modified:
3 years, 6 months ago
Reviewers:
melandory
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, vabr+watchlistpasswordmanager_chromium.org, noyau+watch_chromium.org, marq+watch_chromium.org, gcasto+watchlist_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M ios/chrome/browser/passwords/ios_chrome_save_password_infobar_delegate.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/passwords/ios_chrome_save_password_infobar_delegate.mm View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
jif
ptal
3 years, 6 months ago (2017-06-02 11:20:39 UTC) #4
melandory
On 2017/06/02 11:20:39, jif wrote: > ptal lgtm
3 years, 6 months ago (2017-06-02 11:37:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2919023002/1
3 years, 6 months ago (2017-06-02 11:48:57 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 12:04:48 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b1f1dff926898cb5aa7330a9a558...

Powered by Google App Engine
This is Rietveld 408576698