Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2918993004: Settings: Do not apply cr-actionable to scrollable items (Closed)

Created:
3 years, 6 months ago by stevenjb
Modified:
3 years, 6 months ago
Reviewers:
hcarmona
CC:
chromium-reviews, dbeam+watch-elements_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, dbeam+watch-settings_chromium.org, michaelpg+watch-elements_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Settings: Do not apply cr-actionable to scrollable items The only scrollable container with actionable items that are not already identified are bluetooth devices, so just fix those. BUG=728111 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2918993004 Cr-Commit-Position: refs/heads/master@{#477016} Committed: https://chromium.googlesource.com/chromium/src/+/20cb815a45b037b022d89f4ce1e105eca89ab69c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M chrome/browser/resources/settings/bluetooth_page/bluetooth_subpage.html View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/webui/resources/cr_elements/shared_style_css.html View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
stevenjb
3 years, 6 months ago (2017-06-02 21:28:58 UTC) #3
hcarmona
LGTM
3 years, 6 months ago (2017-06-02 21:39:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2918993004/1
3 years, 6 months ago (2017-06-02 21:56:42 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_TIMED_OUT, build has not started yet; ...
3 years, 6 months ago (2017-06-02 23:58:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2918993004/1
3 years, 6 months ago (2017-06-05 16:07:09 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-05 17:51:05 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/20cb815a45b037b022d89f4ce1e1...

Powered by Google App Engine
This is Rietveld 408576698