Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2918953002: [MD settings] layout of buttons inside toggles and iron-lists (Closed)

Created:
3 years, 6 months ago by dschuyler
Modified:
3 years, 6 months ago
Reviewers:
hcarmona
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] layout of buttons inside toggles and iron-lists My prior CL 2902363002 did not properly account for buttons inside of iron-lists (which will render poorly if overflow is visible, and clip off ripples if overflow is visible); and buttons inside of toggle-buttons. This CL addresses those gaps. BUG=728493, 728490, 728487 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2918953002 Cr-Commit-Position: refs/heads/master@{#476699} Committed: https://chromium.googlesource.com/chromium/src/+/f60d062aad6f02456fb50f4f5d00936d47d08030

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M chrome/browser/resources/settings/on_startup_page/startup_urls_page.html View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/settings_shared_css.html View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
dschuyler
This is a follow-up on https://codereview.chromium.org/2902363002/
3 years, 6 months ago (2017-06-02 00:16:21 UTC) #5
hcarmona
LGTM NIT: Please add screenshot for margin change
3 years, 6 months ago (2017-06-02 01:00:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2918953002/1
3 years, 6 months ago (2017-06-02 17:08:03 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 17:12:55 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f60d062aad6f02456fb50f4f5d00...

Powered by Google App Engine
This is Rietveld 408576698