Move SetCanHaveScrollbars method from WebFrame to WebLocalFrame.

Move SetCanHaveScrollbars method from WebFrame to WebLocalFrame.

All callers already either call through WebLocalFrame, or verify
before the call that the frame is local.

No intended behavior change.

BUG=416660
Review-Url: https://codereview.chromium.org/2918943002
Cr-Commit-Position: refs/heads/master@{#476774}
Committed: https://chromium.googlesource.com/chromium/src/+/302fcddd0418a4916b514ae06658cea7b88b5da6

[Łukasz Anforowicz, 2017-06-01 23:49:42]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-01 23:50:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 01:47:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 01:47:58]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Łukasz Anforowicz, 2017-06-02 16:01:05]

lukasza@chromium.org changed reviewers:
+ dcheng@chromium.org

[Łukasz Anforowicz, 2017-06-02 16:01:06]

dcheng@, can you PTAL?

[dcheng, 2017-06-02 16:29:37]

Hopefully we can keep these sorts of issues in mind and figure out a better way
to do them eventually

https://codereview.chromium.org/2918943002/diff/1/content/renderer/render_vie...
File content/renderer/render_view_impl.cc (right):

https://codereview.chromium.org/2918943002/diff/1/content/renderer/render_vie...
content/renderer/render_view_impl.cc:2192:
webview()->MainFrame()->ToWebLocalFrame()->SetCanHaveScrollbars(
The downcast is a bit unfortunate but I don't have a better suggestion here =)

[dcheng, 2017-06-02 16:29:47]

also lgtm

[Łukasz Anforowicz, 2017-06-02 16:53:50]

On 2017/06/02 16:29:37, dcheng wrote:
> Hopefully we can keep these sorts of issues in mind and figure out a better
way
> to do them eventually
> 
>
https://codereview.chromium.org/2918943002/diff/1/content/renderer/render_vie...
> File content/renderer/render_view_impl.cc (right):
> 
>
https://codereview.chromium.org/2918943002/diff/1/content/renderer/render_vie...
> content/renderer/render_view_impl.cc:2192:
> webview()->MainFrame()->ToWebLocalFrame()->SetCanHaveScrollbars(
> The downcast is a bit unfortunate but I don't have a better suggestion here =)

Yeah - the downcast indicates that we still have a problem, but I think that the
CL is still going in the right direction:

1. Exposing the method from WebLocalFrame rather than from WebFrame will
hopefully mean less chance of new problems cropping up.

2. It is easier (?) to search for ToWebLocalFrame / IsWebRemoteFrame / etc.
rather than for all the methods currently overriden, but not really implemented
by WebRemoteFrameImpl.

[Łukasz Anforowicz, 2017-06-02 16:53:57]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2017-06-02 16:54:12]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 17:02:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 17:02:49]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Łukasz Anforowicz, 2017-06-02 17:07:32]

lukasza@chromium.org changed reviewers:
+ junov@chromium.org

[Łukasz Anforowicz, 2017-06-02 17:07:33]

junov@, could you PTAL do an owners review of
third_party/WebKit/Source/platform/graphics/ ?

[Łukasz Anforowicz, 2017-06-02 17:08:15]

junov@: Oops, wrong CL.  Please ignore....

[Łukasz Anforowicz, 2017-06-02 17:09:17]

lukasza@chromium.org changed reviewers:
+ alexmos@chromium.org
- junov@chromium.org

[Łukasz Anforowicz, 2017-06-02 17:09:18]

alexmos@, could you PTAL do an owners review for //content/renderer changes?

[Łukasz Anforowicz, 2017-06-02 17:11:44]

lukasza@chromium.org changed reviewers:
+ nasko@chromium.org
- alexmos@chromium.org

[Łukasz Anforowicz, 2017-06-02 17:11:44]

Actually, I forgot that Alex is OOO today.  nasko@ - could you PTAL?

[alexmos, 2017-06-02 17:16:14]

alexmos@chromium.org changed reviewers:
+ alexmos@chromium.org

[alexmos, 2017-06-02 17:16:15]

content/ LGTM    (I'm WFH for now :) )

[Łukasz Anforowicz, 2017-06-02 17:19:25]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2017-06-02 17:19:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 17:28:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 17:28:01]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Łukasz Anforowicz, 2017-06-02 17:44:39]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 17:45:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Łukasz Anforowicz, 2017-06-02 18:09:21]

The CQ bit was unchecked by lukasza@chromium.org

[Łukasz Anforowicz, 2017-06-02 18:09:26]

The CQ bit was checked by lukasza@chromium.org

[Łukasz Anforowicz, 2017-06-02 18:09:27]

The patchset sent to the CQ was uploaded after l-g-t-m from dcheng@chromium.org,
alexmos@chromium.org
Link to the patchset: https://codereview.chromium.org/2918943002/#ps20001
(title: "Rebasing...")

[commit-bot: I haz the power, 2017-06-02 18:09:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 20:40:37]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496426966851320,
"parent_rev": "0507e9f17c57e79a10f61eee6c815368977ade54", "commit_rev":
"302fcddd0418a4916b514ae06658cea7b88b5da6"}

[commit-bot: I haz the power, 2017-06-02 20:40:49]

Description was changed from

==========
Move SetCanHaveScrollbars method from WebFrame to WebLocalFrame.

All callers already either call through WebLocalFrame, or verify
before the call that the frame is local.

No intended behavior change.

BUG=416660
==========

to

==========
Move SetCanHaveScrollbars method from WebFrame to WebLocalFrame.

All callers already either call through WebLocalFrame, or verify
before the call that the frame is local.

No intended behavior change.

BUG=416660

Review-Url: https://codereview.chromium.org/2918943002
Cr-Commit-Position: refs/heads/master@{#476774}
Committed:
https://chromium.googlesource.com/chromium/src/+/302fcddd0418a4916b514ae06658...
==========

[commit-bot: I haz the power, 2017-06-02 20:40:51]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/302fcddd0418a4916b514ae06658...