Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 2918933002: [EasyUnlock] Make login work if command line flag is enabled. (Closed)

Created:
3 years, 6 months ago by Tim Song
Modified:
3 years, 6 months ago
Reviewers:
sacomoto
CC:
chromium-reviews, jlklein+watch-tether_chromium.org, tengs+watch-tether_chromium.org, hansberry+watch-tether_chromium.org, jhawkins+watch-tether_chromium.org, lesliewatkins+watch-tether_chromium.org, khorimoto+watch-tether_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[EasyUnlock] Make login work if command line flag is enabled. BUG=728864 Review-Url: https://codereview.chromium.org/2918933002 Cr-Commit-Position: refs/heads/master@{#476730} Committed: https://chromium.googlesource.com/chromium/src/+/15d09411875b70e192ee27969564a2ae32c0ca71

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -7 lines) Patch
M chrome/browser/signin/easy_unlock_service_regular.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service_signin_chromeos.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/proximity_auth/proximity_auth_system.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/proximity_auth/proximity_auth_system.cc View 3 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Tim Song
3 years, 6 months ago (2017-06-01 23:41:37 UTC) #2
sacomoto
lgtm
3 years, 6 months ago (2017-06-02 14:46:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2918933002/1
3 years, 6 months ago (2017-06-02 17:29:09 UTC) #5
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 18:32:27 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/15d09411875b70e192ee27969564...

Powered by Google App Engine
This is Rietveld 408576698