Move IconURLs method from WebFrame to WebLocalFrame

content/renderer/render_view_impl.cc

Index: content/renderer/render_view_impl.cc
diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc
index 301fc74f0f9783133b98628ae9bb3dde2ea8d8cd..291f14402a36ced1b03f9e147c3f8c5874250116 100644
--- a/content/renderer/render_view_impl.cc
+++ b/content/renderer/render_view_impl.cc
@@ -2608,11 +2608,11 @@ void RenderViewImpl::DidStopLoadingIcons() {
 
   // Favicons matter only for the top-level frame. If it is a WebRemoteFrame,
   // just return early.
-  if (webview()->MainFrame()->IsWebRemoteFrame())
+  if (!webview()->MainFrame()->IsWebLocalFrame())

[dcheng, 2017/06/02 16:28:15]

Maybe this logic should be on RenderFrameImpl. WDYT?

[Łukasz Anforowicz, 2017/06/05 22:38:46]

Yes - thanks for pointing this out.  Done.

     return;
 
   WebVector<WebIconURL> icon_urls =
-      webview()->MainFrame()->IconURLs(icon_types);
+      webview()->MainFrame()->ToWebLocalFrame()->IconURLs(icon_types);
 
   std::vector<FaviconURL> urls;
   for (size_t i = 0; i < icon_urls.size(); i++) {