Move IconURLs method from WebFrame to WebLocalFrame

content/renderer/render_view_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view_impl.h"
 
 #include <algorithm>
 #include <cmath>
 #include <memory>
 
@@ skipping 2590 matching lines @@
   if (!urls.empty())
     Send(new ViewHostMsg_UpdateFaviconURL(GetRoutingID(), urls));
 }
 
 void RenderViewImpl::DidStopLoadingIcons() {
   int icon_types = WebIconURL::kTypeFavicon |
                    WebIconURL::kTypeTouchPrecomposed | WebIconURL::kTypeTouch;
 
   // Favicons matter only for the top-level frame. If it is a WebRemoteFrame,
   // just return early.
-  if (webview()->MainFrame()->IsWebRemoteFrame())
+  if (!webview()->MainFrame()->IsWebLocalFrame())

[dcheng, 2017/06/02 16:28:15]

Maybe this logic should be on RenderFrameImpl. WDYT?

[Łukasz Anforowicz, 2017/06/05 22:38:46]

Yes - thanks for pointing this out.  Done.

     return;
 
   WebVector<WebIconURL> icon_urls =
-      webview()->MainFrame()->IconURLs(icon_types);
+      webview()->MainFrame()->ToWebLocalFrame()->IconURLs(icon_types);
 
   std::vector<FaviconURL> urls;
   for (size_t i = 0; i < icon_urls.size(); i++) {
     WebURL url = icon_urls[i].GetIconURL();
     std::vector<gfx::Size> sizes;
     ConvertToFaviconSizes(icon_urls[i].Sizes(), &sizes);
     if (!url.IsEmpty())
       urls.push_back(
           FaviconURL(url, ToFaviconType(icon_urls[i].IconType()), sizes));
   }
@@ skipping 36 matching lines @@
                         input_event.GetCoalescedEventsPointers(), latency_info,
                         dispatch_type);
     return INPUT_EVENT_ACK_STATE_NOT_CONSUMED;
   }
   idle_user_detector_->ActivityDetected();
   return RenderWidget::HandleInputEvent(input_event, latency_info,
                                         dispatch_type);
 }
 
 }  // namespace content