Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 2918883003: Settings: Fix disabled primary buttons (Closed)

Created:
3 years, 6 months ago by stevenjb
Modified:
3 years, 6 months ago
Reviewers:
dschuyler
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Settings: Fix disabled primary buttons Disabled primary buttons should look like other disabled paper buttons. This also removes a copy/pasted --paper-button mixin that is no longer needed (and may be causing minor artifcats). Note: .primary-button is only ised in Printing, People (non CrOS), and Internet. BUG=none CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2918883003 Cr-Commit-Position: refs/heads/master@{#477012} Committed: https://chromium.googlesource.com/chromium/src/+/633b706243f9c67ff68260c0a5571b8c79170e45

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -12 lines) Patch
M chrome/browser/resources/settings/settings_shared_css.html View 1 chunk +1 line, -12 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
stevenjb
3 years, 6 months ago (2017-06-02 18:35:47 UTC) #3
dschuyler
lgtm
3 years, 6 months ago (2017-06-02 22:51:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2918883003/1
3 years, 6 months ago (2017-06-02 22:53:36 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/309802)
3 years, 6 months ago (2017-06-03 00:59:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2918883003/1
3 years, 6 months ago (2017-06-05 16:06:52 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-05 17:40:13 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/633b706243f9c67ff68260c0a557...

Powered by Google App Engine
This is Rietveld 408576698