Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 2918813002: Refactor SuppressedHTTPSFormsFetcher to use GetLoginsForSameOrganizationName. (Closed)

Created:
3 years, 6 months ago by engedy
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Refactor SuppressedHTTPSFormsFetcher to use GetLoginsForSameOrganizationName. This results in no change in functionality, but is done in preparation for refactoring SuppressedHTTPSFormsFetcher to return not only suppressed HTTPS credentials, but also two other flavors of suppressed credentials. As an immediate benefit, this CL allows cleaning up password_manager_unittests. BUG=720599 Review-Url: https://codereview.chromium.org/2911433003 Cr-Original-Commit-Position: refs/heads/master@{#475325} Review-Url: https://codereview.chromium.org/2918813002 . Cr-Commit-Position: refs/branch-heads/3112@{#85} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/863169d1b3f9bc3783d53fdbe686d715f1059c41

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
engedy
3 years, 6 months ago (2017-06-01 12:34:33 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
863169d1b3f9bc3783d53fdbe686d715f1059c41.

Powered by Google App Engine
This is Rietveld 408576698