Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 2918743002: [i18n] login UI i18n-content and values to $i18n{} (Closed)

Created:
3 years, 6 months ago by dschuyler
Modified:
3 years, 6 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[i18n] login UI i18n-content and values to $i18n{} This CL changes the old i18n-content/i18n-values to the new (faster) $i18n{}. There should be no functionality changes apparent to the user. BUG=692763 Review-Url: https://codereview.chromium.org/2918743002 Cr-Commit-Position: refs/heads/master@{#476356} Committed: https://chromium.googlesource.com/chromium/src/+/27b6f79ce778bb7f2bc9a15a27e0d86d6f1656e8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -97 lines) Patch
M ui/login/account_picker/md_screen_account_picker.html View 1 chunk +1 line, -2 lines 0 comments Download
M ui/login/account_picker/md_user_pod_template.html View 8 chunks +59 lines, -46 lines 0 comments Download
M ui/login/account_picker/screen_account_picker.html View 1 chunk +1 line, -2 lines 0 comments Download
M ui/login/account_picker/user_pod_template.html View 7 chunks +60 lines, -47 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
dschuyler
3 years, 6 months ago (2017-06-01 00:27:38 UTC) #4
xiyuan
lgtm
3 years, 6 months ago (2017-06-01 16:19:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2918743002/1
3 years, 6 months ago (2017-06-01 18:15:08 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-06-01 18:21:05 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/27b6f79ce778bb7f2bc9a15a27e0...

Powered by Google App Engine
This is Rietveld 408576698