Source/platform/graphics/media/MediaPlayer.h - Issue 291873002: Eliminate MediaPlayer & MediaPlayerClient abstractions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/graphics/media/MediaPlayer.h

Issue 291873002: Eliminate MediaPlayer & MediaPlayerClient abstractions (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Removed one more unused method Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/mediasource/HTMLVideoElementMediaSource.cpp ('K') | « Source/modules/mediasource/HTMLVideoElementMediaSource.cpp ('k') | Source/web/WebMediaPlayerClientImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/graphics/media/MediaPlayer.h

diff --git a/Source/platform/graphics/media/MediaPlayer.h b/Source/platform/graphics/media/MediaPlayer.h

index 72ec05b9006658f574f02ce8a7ba794c08bce763..e1a28872438a9cc4711c089637d57ccae94547db 100644

--- a/Source/platform/graphics/media/MediaPlayer.h

+++ b/Source/platform/graphics/media/MediaPlayer.h

@@ -117,9 +117,7 @@ public:

virtual void pause() = 0;

virtual bool supportsSave() const = 0;

- virtual IntSize naturalSize() const = 0;

- virtual bool hasVideo() const = 0;

virtual bool hasAudio() const = 0;

acolwell GONE FROM CHROMIUM 2014/05/20 16:40:21 Please remove this as well so that both hasXXX met

virtual double duration() const = 0;

@@ -160,15 +158,10 @@ public:

virtual bool hasSingleSecurityOrigin() const = 0;

- virtual bool didPassCORSAccessCheck() const = 0;

// Time value in the movie's time scale. It is only necessary to override this if the media

// engine uses rational numbers to represent media time.

virtual double mediaTimeForTimeValue(double timeValue) const = 0;

- virtual unsigned decodedFrameCount() const = 0;

- virtual unsigned droppedFrameCount() const = 0;

- virtual unsigned corruptedFrameCount() const = 0;

virtual unsigned audioDecodedByteCount() const = 0;

virtual unsigned videoDecodedByteCount() const = 0;

acolwell GONE FROM CHROMIUM 2014/05/20 16:40:21 Please remove these two as well so that all the st