Eliminate MediaPlayer & MediaPlayerClient abstractions

Source/platform/graphics/media/MediaPlayer.h

 /*
  * Copyright (C) 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 27 matching lines @@
 class WebInbandTextTrack;
 class WebLayer;
 class WebMediaSource;
 }
 
 namespace WebCore {
 
 class AudioSourceProvider;
 class GraphicsContext;
 class IntRect;
 class IntSize;

[acolwell GONE FROM CHROMIUM, 2014/05/20 16:40:21]

I think you can remove this now

 class KURL;
 class MediaPlayer;
 class TimeRanges;
 
 // GL types as defined in OpenGL ES 2.0 header file gl2.h from khronos.org.
 // That header cannot be included directly due to a conflict with NPAPI headers.
 // See crbug.com/328085.
 typedef unsigned GC3Denum;
 typedef int GC3Dint;
 
@@ skipping 51 matching lines @@
 
     MediaPlayer() { }
     virtual ~MediaPlayer() { }
 
     virtual void load(blink::WebMediaPlayer::LoadType, const String& url, blink::WebMediaPlayer::CORSMode) = 0;
 
     virtual void play() = 0;
     virtual void pause() = 0;
 
     virtual bool supportsSave() const = 0;
-    virtual IntSize naturalSize() const = 0;
 
-    virtual bool hasVideo() const = 0;
     virtual bool hasAudio() const = 0;

[acolwell GONE FROM CHROMIUM, 2014/05/20 16:40:21]

Please remove this as well so that both hasXXX methods are removed.

 
     virtual double duration() const = 0;
 
     virtual double currentTime() const = 0;
 
     virtual void seek(double) = 0;
 
     virtual bool seeking() const = 0;
 
     virtual double rate() const = 0;
@@ skipping 19 matching lines @@
 
     enum Preload { None, MetaData, Auto };
     virtual void setPreload(Preload) = 0;
 
     virtual void showFullscreenOverlay() = 0;
     virtual void hideFullscreenOverlay() = 0;
     virtual bool canShowFullscreenOverlay() const = 0;
 
     virtual bool hasSingleSecurityOrigin() const = 0;
 
-    virtual bool didPassCORSAccessCheck() const = 0;
-
     // Time value in the movie's time scale. It is only necessary to override this if the media
     // engine uses rational numbers to represent media time.
     virtual double mediaTimeForTimeValue(double timeValue) const = 0;
 
-    virtual unsigned decodedFrameCount() const = 0;
-    virtual unsigned droppedFrameCount() const = 0;
-    virtual unsigned corruptedFrameCount() const = 0;
     virtual unsigned audioDecodedByteCount() const = 0;
     virtual unsigned videoDecodedByteCount() const = 0;

[acolwell GONE FROM CHROMIUM, 2014/05/20 16:40:21]

Please remove these two as well so that all the stats methods are now removed.

 
 #if ENABLE(WEB_AUDIO)
     virtual AudioSourceProvider* audioSourceProvider() = 0;
 #endif
     virtual blink::WebMediaPlayer* webMediaPlayer() const = 0;
 };
 
 }
 
 #endif // MediaPlayer_h