Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2918683002: Roll closure compiler (Closed)

Created:
3 years, 6 months ago by dpapad
Modified:
3 years, 6 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, scottchen
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll closure compiler Change log: https://github.com/google/closure-compiler/compare/ee44867683988d37c9cdb1b5c9557fe984c87135...e061fc7bd4ac37730534828a9484d528fcd80eb5 chrome_extensions.js: f9877b62e50844da51a50374dbc3c98d31d85ce3 -> 927e44d6e32d7b2f50ddb2b20f6515b79a0914b3 polymer-1.0.js: 5b180dcd7e8913c66386a675086b99aaad2f0a53 -> cc53ce238def6597f71ddd75e961011edb18e6a3 R=dbeam@chromium.org BUG=721073 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2918683002 . Cr-Commit-Position: refs/heads/master@{#476093} Committed: https://chromium.googlesource.com/chromium/src/+/062b17c082a63b24de989a5f79c77d6382e1aa15

Patch Set 1 #

Patch Set 2 : Fix compile errors. #

Patch Set 3 : Redo because local branch got messed up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+467 lines, -109 lines) Patch
M chrome/browser/resources/md_bookmarks/list.js View 1 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/resources/md_bookmarks/types.js View 1 1 chunk +0 lines, -36 lines 0 comments Download
M third_party/closure_compiler/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M third_party/closure_compiler/compiler/compiler.jar View 1 2 Binary file 0 comments Download
M third_party/closure_compiler/externs/chrome_extensions.js View 8 chunks +370 lines, -69 lines 0 comments Download
M third_party/closure_compiler/externs/polymer-1.0.js View 6 chunks +93 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
dpapad
3 years, 6 months ago (2017-05-31 22:09:24 UTC) #2
Dan Beam
lgtm
3 years, 6 months ago (2017-05-31 22:17:58 UTC) #3
dpapad
3 years, 6 months ago (2017-05-31 23:44:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
062b17c082a63b24de989a5f79c77d6382e1aa15 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698