Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 2918663004: Condition ::RecordLinuxDistro against OS_LINUX, not USE_X11 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 3 weeks ago by tonikitoo
Modified:
1 month, 2 weeks ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Condition ::RecordLinuxDistro against OS_LINUX, not USE_X11 There is nothing that makes ::RecordLinuxDistro X11 specific. Still it gets declared guarded by USE_OZONE and called guarded by USE_X11. CL syncs up the declaration and call sites, and fixes the OzoneLinux FYI bot. BUG=295089

Patch Set 1 #

Total comments: 1

Patch Set 2 : address thestig's feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
Trybot results:
Commit queue not available (can’t edit this change).

Messages

Total messages: 11 (5 generated)
tonikitoo
1 month, 3 weeks ago (2017-06-01 03:00:39 UTC) #4
Lei Zhang
https://codereview.chromium.org/2918663004/diff/1/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc File chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc (left): https://codereview.chromium.org/2918663004/diff/1/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc#oldcode467 chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc:467: #if defined(USE_X11) && !defined(OS_CHROMEOS) This matches the #if that ...
1 month, 3 weeks ago (2017-06-01 04:27:09 UTC) #7
tonikitoo
On 2017/06/01 04:27:09, Lei Zhang wrote: > https://codereview.chromium.org/2918663004/diff/1/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc > File chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc (left): > > https://codereview.chromium.org/2918663004/diff/1/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc#oldcode467 ...
1 month, 2 weeks ago (2017-06-01 11:51:52 UTC) #8
tonikitoo
On 2017/06/01 11:51:52, tonikitoo wrote: > On 2017/06/01 04:27:09, Lei Zhang wrote: > > > ...
1 month, 2 weeks ago (2017-06-01 11:59:08 UTC) #9
timbrown
On 2017/06/01 11:59:08, tonikitoo wrote: > On 2017/06/01 11:51:52, tonikitoo wrote: > > On 2017/06/01 ...
1 month, 2 weeks ago (2017-06-01 16:33:08 UTC) #10
Lei Zhang
1 month, 2 weeks ago (2017-06-01 19:12:20 UTC) #11
https://codereview.chromium.org/2917483002/ already landed, so you probably need
to rebase. We can continue and tweak this more as needed.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 25c286973