Prevent gap when gesture-dragging in stacked tab mode

Prevent gap when gesture-dragging in stacked tab mode

In stacked tab mode, if the active tab's x-position
is maximal and there is a stacked tab to its left,
gesture-dragging the active tab to the left will
produce a gap in the tabstrip. Prevent this from
happening by invoking AdjustStackedTabs() rather than
ResetToIdealState(), as is done in the symmetric case
of gesture-dragging to the right.

BUG=454479
TEST=StackedTabStripLayoutTest.DragActiveTabExisting

Review-Url: https://codereview.chromium.org/2918653002
Cr-Commit-Position: refs/heads/master@{#476448}
Committed: https://chromium.googlesource.com/chromium/src/+/c6adb78933fa7fd7a0259ab6ff25620dd0a875f8

[tdanderson, 2017-05-31 21:06:18]

The CQ bit was checked by tdanderson@chromium.org to run a CQ dry run

[tdanderson, 2017-05-31 21:06:56]

tdanderson@chromium.org changed reviewers:
+ sky@chromium.org

[tdanderson, 2017-05-31 21:06:56]

Scott, can you please take a look?

[commit-bot: I haz the power, 2017-05-31 21:07:23]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 22:13:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 22:13:41]

Dry run: This issue passed the CQ dry run.

[sky, 2017-05-31 22:21:18]

This seems right. Could you add test coverage?

[tdanderson, 2017-06-01 19:16:45]

Description was changed from

==========
Prevent gap when gesture-dragging in stacked tab mode

In stacked tab mode, if the active tab's x-position
is maximal and there is a stacked tab to its left,
gesture-dragging the active tab to the left will
produce a gap in the tabstrip. Prevent this from
happening by invoking AdjustStackedTabs() rather than
ResetToIdealState(), as is done in the symmetric case
of gesture-dragging to the right.

BUG=454479
==========

to

==========
Prevent gap when gesture-dragging in stacked tab mode

In stacked tab mode, if the active tab's x-position
is maximal and there is a stacked tab to its left,
gesture-dragging the active tab to the left will
produce a gap in the tabstrip. Prevent this from
happening by invoking AdjustStackedTabs() rather than
ResetToIdealState(), as is done in the symmetric case
of gesture-dragging to the right.

BUG=454479
TEST=StackedTabStripLayoutTest.DragActiveTabExisting
==========

[tdanderson, 2017-06-01 19:20:51]

Please take a look at Patch Set 2.

[tdanderson, 2017-06-01 19:21:07]

The CQ bit was checked by tdanderson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-01 19:21:43]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 20:16:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-01 20:16:22]

Dry run: This issue passed the CQ dry run.

[sky, 2017-06-01 21:52:37]

LGTM

[tdanderson, 2017-06-01 21:54:52]

The CQ bit was checked by tdanderson@chromium.org

[commit-bot: I haz the power, 2017-06-01 21:55:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 22:01:55]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496354092228410,
"parent_rev": "4f75e35ab706cc59d28172071a44df09a5129af9", "commit_rev":
"e2748d4b91490ef3716436ce81a42e975131b3cf"}

[commit-bot: I haz the power, 2017-06-01 22:02:07]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496354092228410,
"parent_rev": "816d3a265c5315f0f39b1691be9b9b048b8ceaa8", "commit_rev":
"c6adb78933fa7fd7a0259ab6ff25620dd0a875f8"}

[commit-bot: I haz the power, 2017-06-01 22:02:17]

Description was changed from

==========
Prevent gap when gesture-dragging in stacked tab mode

In stacked tab mode, if the active tab's x-position
is maximal and there is a stacked tab to its left,
gesture-dragging the active tab to the left will
produce a gap in the tabstrip. Prevent this from
happening by invoking AdjustStackedTabs() rather than
ResetToIdealState(), as is done in the symmetric case
of gesture-dragging to the right.

BUG=454479
TEST=StackedTabStripLayoutTest.DragActiveTabExisting
==========

to

==========
Prevent gap when gesture-dragging in stacked tab mode

In stacked tab mode, if the active tab's x-position
is maximal and there is a stacked tab to its left,
gesture-dragging the active tab to the left will
produce a gap in the tabstrip. Prevent this from
happening by invoking AdjustStackedTabs() rather than
ResetToIdealState(), as is done in the symmetric case
of gesture-dragging to the right.

BUG=454479
TEST=StackedTabStripLayoutTest.DragActiveTabExisting

Review-Url: https://codereview.chromium.org/2918653002
Cr-Commit-Position: refs/heads/master@{#476448}
Committed:
https://chromium.googlesource.com/chromium/src/+/c6adb78933fa7fd7a0259ab6ff25...
==========

[commit-bot: I haz the power, 2017-06-01 22:02:18]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c6adb78933fa7fd7a0259ab6ff25...