Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 2918623003: [vpython] Verify environment, named installs. (Closed)

Created:
3 years, 6 months ago by dnj
Modified:
3 years, 6 months ago
Reviewers:
Sergey Berezin
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

[vpython] Verify environment, named installs. Support installation of named enviornments, which are VirtualEnv whose name is explicitly specified instead of implicitly inferred from the supplied hash. This can be used by systems that want to use "vpython" to bootstrap a VirtualEnv in a known place instead of default usage. Since the specification is no longer always derived from the name, we add a step to verify that a given VirtualEnv actally matches the expected VirutalEnv. If it doesn't, it's considered incomplete and reprovisioned. This allows a path to upgrade named "vpython" roots from one installation to another, as well as additional cheap sanity checking to the basic "vpython" assumption that a stamped VirtualEnv is complete. BUG=None TEST=local - Ran "install" and setup normally, appears to work. R=sergeyberezin@chromium.org Review-Url: https://codereview.chromium.org/2918623003 Committed: https://github.com/luci/luci-go/commit/7303ecf220ab1d616da726f99bf70116bd07eec6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -51 lines) Patch
M vpython/application/subcommand_delete.go View 1 chunk +1 line, -1 line 0 comments Download
M vpython/application/subcommand_install.go View 1 chunk +13 lines, -1 line 0 comments Download
M vpython/application/subcommand_verify.go View 1 chunk +4 lines, -1 line 0 comments Download
M vpython/spec/spec.go View 2 chunks +32 lines, -5 lines 0 comments Download
M vpython/spec/spec_test.go View 1 chunk +26 lines, -21 lines 0 comments Download
M vpython/venv/config.go View 5 chunks +29 lines, -22 lines 0 comments Download
M vpython/venv/venv.go View 2 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
dnj
3 years, 6 months ago (2017-05-31 19:20:47 UTC) #1
Sergey Berezin
LGTM, thanks!
3 years, 6 months ago (2017-05-31 19:34:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2918623003/1
3 years, 6 months ago (2017-05-31 20:45:45 UTC) #4
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 20:52:48 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/7303ecf220ab1d616da726f99bf70116bd07eec6

Powered by Google App Engine
This is Rietveld 408576698