Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 2918613003: MD settings: make update errors text-selectable. (Closed)

Created:
3 years, 6 months ago by scottchen
Modified:
3 years, 6 months ago
Reviewers:
hcarmona
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD settings: make update errors text-selectable. BUG=715193 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2918613003 Cr-Commit-Position: refs/heads/master@{#476499} Committed: https://chromium.googlesource.com/chromium/src/+/00471e4dc17aed2e8aea47b4df93162f81cdbedf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/resources/settings/about_page/about_page.html View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
scottchen
3 years, 6 months ago (2017-05-31 23:05:21 UTC) #3
hcarmona
lgtm
3 years, 6 months ago (2017-06-01 17:15:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2918613003/1
3 years, 6 months ago (2017-06-01 20:45:58 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/228819)
3 years, 6 months ago (2017-06-01 22:26:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2918613003/1
3 years, 6 months ago (2017-06-01 22:55:22 UTC) #10
commit-bot: I haz the power
3 years, 6 months ago (2017-06-02 00:31:49 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/00471e4dc17aed2e8aea47b4df93...

Powered by Google App Engine
This is Rietveld 408576698