Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2918583003:
Fix BOOLEAN truncation warning in sync_policy.cc. (Closed)
|
Created:
3 years, 6 months ago by Bret Modified:
3 years, 6 months ago Reviewers:
Will Harris CC:
chromium-reviews, wfh+watch_chromium.org, pennymac+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix BOOLEAN truncation warning in sync_policy.cc.
PVS-Studio gave this warning:
sandbox\win\src\sync_policy.cc(198): warning V724: Converting type
'uint32_t' to type 'BOOLEAN' can lead to a loss of high-order bits.
Non-zero value can become 'FALSE'.
Since initial_state comes from an IPC it seems like this might actually
happen in practice.
BUG=697659
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
Review-Url: https://codereview.chromium.org/2918583003
Cr-Commit-Position: refs/heads/master@{#481200}
Committed: https://chromium.googlesource.com/chromium/src/+/9d187859c424c34fc77448d5fa56515f30b8ceed
Patch Set 1 #Patch Set 2 : rebase #
Messages
Total messages: 18 (14 generated)
Description was changed from ========== Fix BOOLEAN truncation warning in sync_policy_test.cc. PVS-Studio gave this warning: sandbox\win\src\sync_policy.cc(198): warning V724: Converting type 'uint32_t' to type 'BOOLEAN' can lead to a loss of high-order bits. Non-zero value can become 'FALSE'. Since initial_state comes from an IPC it seems like this might actually happen in practice. BUG=697659 ========== to ========== Fix BOOLEAN truncation warning in sync_policy_test.cc. PVS-Studio gave this warning: sandbox\win\src\sync_policy.cc(198): warning V724: Converting type 'uint32_t' to type 'BOOLEAN' can lead to a loss of high-order bits. Non-zero value can become 'FALSE'. Since initial_state comes from an IPC it seems like this might actually happen in practice. BUG=697659 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng ==========
The CQ bit was checked by bsep@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win10_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win10_chromium_x6...)
The CQ bit was checked by bsep@chromium.org to run a CQ dry run
Description was changed from ========== Fix BOOLEAN truncation warning in sync_policy_test.cc. PVS-Studio gave this warning: sandbox\win\src\sync_policy.cc(198): warning V724: Converting type 'uint32_t' to type 'BOOLEAN' can lead to a loss of high-order bits. Non-zero value can become 'FALSE'. Since initial_state comes from an IPC it seems like this might actually happen in practice. BUG=697659 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng ========== to ========== Fix BOOLEAN truncation warning in sync_policy.cc. PVS-Studio gave this warning: sandbox\win\src\sync_policy.cc(198): warning V724: Converting type 'uint32_t' to type 'BOOLEAN' can lead to a loss of high-order bits. Non-zero value can become 'FALSE'. Since initial_state comes from an IPC it seems like this might actually happen in practice. BUG=697659 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng ==========
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
bsep@chromium.org changed reviewers: + wfh@chromium.org
lgtm
The CQ bit was checked by wfh@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498050003475100,
"parent_rev": "0b186cb446238e11022f8d2f590bb20840e9d2fa", "commit_rev":
"9d187859c424c34fc77448d5fa56515f30b8ceed"}
Message was sent while issue was closed.
Description was changed from ========== Fix BOOLEAN truncation warning in sync_policy.cc. PVS-Studio gave this warning: sandbox\win\src\sync_policy.cc(198): warning V724: Converting type 'uint32_t' to type 'BOOLEAN' can lead to a loss of high-order bits. Non-zero value can become 'FALSE'. Since initial_state comes from an IPC it seems like this might actually happen in practice. BUG=697659 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng ========== to ========== Fix BOOLEAN truncation warning in sync_policy.cc. PVS-Studio gave this warning: sandbox\win\src\sync_policy.cc(198): warning V724: Converting type 'uint32_t' to type 'BOOLEAN' can lead to a loss of high-order bits. Non-zero value can become 'FALSE'. Since initial_state comes from an IPC it seems like this might actually happen in practice. BUG=697659 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng Review-Url: https://codereview.chromium.org/2918583003 Cr-Commit-Position: refs/heads/master@{#481200} Committed: https://chromium.googlesource.com/chromium/src/+/9d187859c424c34fc77448d5fa56... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/9d187859c424c34fc77448d5fa56... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
