Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 2918563004: Milo: Fix deployment (Closed)

Created:
3 years, 6 months ago by Ryan Tseng
Modified:
3 years, 6 months ago
Reviewers:
nodir
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Milo: Fix deployment https://codereview.chromium.org/2856273004 broke deployment for Milo due to the difference in directory structure between the test environment and the prod environment. This makes template path something that the module that calls the middleware has to pass in, to allow for different modules to use the template bundle. BUG=712431 Review-Url: https://codereview.chromium.org/2918563004 Committed: https://github.com/luci/luci-go/commit/f5757f6f5ad535a7c6648531c06c5b5955ccbb39

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M milo/appengine/buildbot/html_test.go View 1 chunk +1 line, -1 line 0 comments Download
M milo/appengine/common/middleware.go View 2 chunks +6 lines, -5 lines 0 comments Download
M milo/appengine/frontend/main.go View 1 chunk +1 line, -1 line 0 comments Download
M milo/appengine/frontend/main_test.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Ryan Tseng
Doing this to fix deployment. I think next I will remove html.go from each of ...
3 years, 6 months ago (2017-05-31 19:31:28 UTC) #4
nodir
lgtm On 2017/05/31 19:31:28, Ryan Tseng wrote: > Doing this to fix deployment. I think ...
3 years, 6 months ago (2017-05-31 21:28:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2918563004/1
3 years, 6 months ago (2017-05-31 21:28:39 UTC) #9
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 21:35:14 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/f5757f6f5ad535a7c6648531c06c5b5955ccbb39

Powered by Google App Engine
This is Rietveld 408576698