Remove dead code related to the diagnostics server.

Remove dead code related to the diagnostics server.

BUG=
R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/7e32f3bd7ce5e9495ed80bdb9b114806f62a8af9

[devoncarew, 2017-05-31 14:06:31]

devoncarew@google.com changed reviewers:
+ brianwilkerson@google.com, paulberry@google.com

[devoncarew, 2017-05-31 14:06:31]

Remove dead code related to the diagnostics server - the non-driver diagnostics
page, and the older driver diagnostics page.

[Brian Wilkerson, 2017-05-31 14:54:43]

Other than the commented on utilities, lgtm.

https://codereview.chromium.org/2918553002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/server/http_server.dart (right):

https://codereview.chromium.org/2918553002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/server/http_server.dart:161: * A
[AbstractGetHandler] that always returns the given error message.
nit: "A" --> "An"

https://codereview.chromium.org/2918553002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/status/ast_writer.dart (left):

https://codereview.chromium.org/2918553002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/status/ast_writer.dart:15: class AstWriter extends
UnifyingAstVisitor with TreeWriter {
It has frequently been very useful to see the AST created. I think we should
keep this and consider adding a "Get Results" button / link for files being
analyzed that would enable us to get analysis results on demand.

https://codereview.chromium.org/2918553002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/status/element_writer.dart (left):

https://codereview.chromium.org/2918553002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/status/element_writer.dart:16: class ElementWriter
extends GeneralizingElementVisitor with TreeWriter {
It has frequently been very useful to see the element model. I think we should
keep this and consider adding a "Get Results" button / link for files being
analyzed that would enable us to get analysis results on demand.

https://codereview.chromium.org/2918553002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/status/tree_writer.dart (left):

https://codereview.chromium.org/2918553002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/status/tree_writer.dart:16: abstract class
TreeWriter {
This would need to stay because of the subclasses.

[devoncarew, 2017-06-01 16:59:12]

Re-added the files. We should consider removing them at some point however if we
don't hook them up to the diagnostics page. The code will tend to bit-rot if not
in use, and will always be available in git history.

https://codereview.chromium.org/2918553002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/server/http_server.dart (right):

https://codereview.chromium.org/2918553002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/server/http_server.dart:161: * A
[AbstractGetHandler] that always returns the given error message.
On 2017/05/31 14:54:43, Brian Wilkerson wrote:
> nit: "A" --> "An"

Done.

https://codereview.chromium.org/2918553002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/status/ast_writer.dart (left):

https://codereview.chromium.org/2918553002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/status/ast_writer.dart:15: class AstWriter extends
UnifyingAstVisitor with TreeWriter {
On 2017/05/31 14:54:43, Brian Wilkerson wrote:
> It has frequently been very useful to see the AST created. I think we should
> keep this and consider adding a "Get Results" button / link for files being
> analyzed that would enable us to get analysis results on demand.

Done.

https://codereview.chromium.org/2918553002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/status/element_writer.dart (left):

https://codereview.chromium.org/2918553002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/status/element_writer.dart:16: class ElementWriter
extends GeneralizingElementVisitor with TreeWriter {
On 2017/05/31 14:54:43, Brian Wilkerson wrote:
> It has frequently been very useful to see the element model. I think we should
> keep this and consider adding a "Get Results" button / link for files being
> analyzed that would enable us to get analysis results on demand.

Done.

https://codereview.chromium.org/2918553002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/status/tree_writer.dart (left):

https://codereview.chromium.org/2918553002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/status/tree_writer.dart:16: abstract class
TreeWriter {
On 2017/05/31 14:54:43, Brian Wilkerson wrote:
> This would need to stay because of the subclasses.

Done.

[Brian Wilkerson, 2017-06-01 17:00:41]

lgtm

[devoncarew, 2017-06-01 17:31:30]

Description was changed from

==========
Remove dead code related to the diagnostics server.

BUG=
==========

to

==========
Remove dead code related to the diagnostics server.

BUG=
R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/7e32f3bd7ce5e9495ed80bdb9b114806f62a8af9
==========

[devoncarew, 2017-06-01 17:31:32]

Committed patchset #3 (id:40001) manually as
7e32f3bd7ce5e9495ed80bdb9b114806f62a8af9 (presubmit successful).