Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(905)

Unified Diff: pkg/analysis_server/lib/src/server/http_server.dart

Issue 2918553002: Remove dead code related to the diagnostics server. (Closed)
Patch Set: grammar Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/status/get_handler.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/server/http_server.dart
diff --git a/pkg/analysis_server/lib/src/server/http_server.dart b/pkg/analysis_server/lib/src/server/http_server.dart
index 53a12e49c0e6f73f24675a8a8a486d363213101e..67705d471e1d1180804675cab7dfdcacbebae55f 100644
--- a/pkg/analysis_server/lib/src/server/http_server.dart
+++ b/pkg/analysis_server/lib/src/server/http_server.dart
@@ -8,7 +8,6 @@ import 'dart:io';
import 'package:analysis_server/src/channel/web_socket_channel.dart';
import 'package:analysis_server/src/socket_server.dart';
import 'package:analysis_server/src/status/diagnostics.dart';
-import 'package:analysis_server/src/status/get_handler.dart';
/**
* Instances of the class [HttpServer] implement a simple HTTP server. The
@@ -96,11 +95,10 @@ class HttpAnalysisServer {
void _handleGetRequest(HttpRequest request) {
if (getHandler == null) {
if (socketServer.analysisServer.options.enableNewAnalysisDriver) {
- // TODO(devoncarew): Remove GetHandler2.
getHandler = new DiagnosticsSite(socketServer, _printBuffer);
} else {
- // TODO(devoncarew): GetHandler is essentially dead code.
- getHandler = new GetHandler(socketServer, _printBuffer);
+ getHandler = new ErrorGetHandler(
+ 'Diagnostics only supported for the new analysis driver.');
}
}
getHandler.handleGetRequest(request);
@@ -158,3 +156,21 @@ abstract class AbstractGetHandler {
*/
void handleGetRequest(HttpRequest request);
}
+
+/**
+ * An [AbstractGetHandler] that always returns the given error message.
+ */
+class ErrorGetHandler extends AbstractGetHandler {
+ final String message;
+
+ ErrorGetHandler(this.message);
+
+ @override
+ void handleGetRequest(HttpRequest request) {
+ HttpResponse response = request.response;
+ response.statusCode = HttpStatus.NOT_FOUND;
+ response.headers.contentType = ContentType.TEXT;
+ response.write(message);
+ response.close();
+ }
+}
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/status/get_handler.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698