Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2918543002: Add username field discovery heuristic. (Closed)

Created:
3 years, 6 months ago by pkalinnikov
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Add username field discovery heuristic. There are some cases when autofill can't find a username field for autocompletion. For example, if the field is created dynamically in JavaScript. This CL introduces a heuristic which is used as a fallback in such cases to find a username field. When password form autocompletion is about to happen with unknown username field, the heuristic searches for the closest visible autocompletable non-password text element preceding the password element. If one found, it is believed to be the username field. BUG=710374, 606736, 586465, 710003 Review-Url: https://codereview.chromium.org/2889393002 Cr-Original-Commit-Position: refs/heads/master@{#475481} Review-Url: https://codereview.chromium.org/2918543002 . Cr-Commit-Position: refs/branch-heads/3112@{#52} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/525e06d30faf3fdbfb85e2b0e1e7c0c1bdc031e5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -86 lines) Patch
M chrome/renderer/autofill/password_autofill_agent_browsertest.cc View 14 chunks +58 lines, -61 lines 0 comments Download
M components/autofill/content/renderer/password_autofill_agent.h View 2 chunks +6 lines, -6 lines 0 comments Download
M components/autofill/content/renderer/password_autofill_agent.cc View 5 chunks +59 lines, -19 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
pkalinnikov
3 years, 6 months ago (2017-05-31 13:49:55 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
525e06d30faf3fdbfb85e2b0e1e7c0c1bdc031e5.

Powered by Google App Engine
This is Rietveld 408576698