Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1204)

Issue 2918533002: Updates to the diagnostics page. (Closed)

Created:
3 years, 6 months ago by devoncarew
Modified:
3 years, 6 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : use integer division #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -23 lines) Patch
M pkg/analysis_server/lib/src/analysis_server.dart View 1 chunk +9 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/status/diagnostics.dart View 1 8 chunks +27 lines, -12 lines 0 comments Download
M pkg/analysis_server/lib/src/status/pages.dart View 3 chunks +9 lines, -11 lines 0 comments Download
M pkg/analysis_server/pubspec.yaml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
devoncarew
Some minor updates to the analysis server's diagnostics page.
3 years, 6 months ago (2017-05-31 13:44:34 UTC) #3
devoncarew
Some minor updates to the analysis server's diagnostics page.
3 years, 6 months ago (2017-05-31 13:44:35 UTC) #4
Brian Wilkerson
lgtm https://codereview.chromium.org/2918533002/diff/1/pkg/analysis_server/lib/src/status/diagnostics.dart File pkg/analysis_server/lib/src/status/diagnostics.dart (right): https://codereview.chromium.org/2918533002/diff/1/pkg/analysis_server/lib/src/status/diagnostics.dart#newcode901 pkg/analysis_server/lib/src/status/diagnostics.dart:901: requestCount > 0 ? (perf.requestLatency / requestCount) : ...
3 years, 6 months ago (2017-05-31 13:50:51 UTC) #6
scheglov
LGTM
3 years, 6 months ago (2017-05-31 13:57:15 UTC) #7
devoncarew
https://codereview.chromium.org/2918533002/diff/1/pkg/analysis_server/lib/src/status/diagnostics.dart File pkg/analysis_server/lib/src/status/diagnostics.dart (right): https://codereview.chromium.org/2918533002/diff/1/pkg/analysis_server/lib/src/status/diagnostics.dart#newcode901 pkg/analysis_server/lib/src/status/diagnostics.dart:901: requestCount > 0 ? (perf.requestLatency / requestCount) : 0; ...
3 years, 6 months ago (2017-05-31 14:14:31 UTC) #8
devoncarew
3 years, 6 months ago (2017-05-31 14:15:24 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
02f7f5fee7d1534d16a189c393e8b887489c6ab5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698