Updates to the diagnostics page.

pkg/analysis_server/lib/src/status/diagnostics.dart

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:convert';
 import 'dart:io';
 
 import 'package:analysis_server/protocol/protocol_generated.dart';
 import 'package:analysis_server/src/analysis_server.dart';
 import 'package:analysis_server/src/domain_completion.dart';
@@ skipping 90 matching lines @@
 }
 
 td.pre {
   white-space: pre;
 }
 
 .nowrap {
   white-space: nowrap;
 }
 
+.scroll-table {
+  max-height: 190px;
+  overflow-x: auto;
+}
+
 .footer {
   padding-top: 3rem;
   padding-bottom: 3rem;
   margin-top: 3rem;
   line-height: 1.75;
   color: #7a7a7a;
   border-top: 1px solid #eee;
 }
 
 .footer strong {
@@ skipping 300 matching lines @@
 class ProfilePage extends DiagnosticPageWithNav {
   ProfilePage(DiagnosticsSite site)
       : super(site, 'profile', 'Profiling Info',
             description: 'Profiling performance tag data.');
 
   @override
   void generateContent(Map<String, String> params) {
     // prepare sorted tags
     List<PerformanceTag> tags = PerformanceTag.all.toList();
     tags.remove(ServerPerformanceStatistics.idle);
-    tags.removeWhere((tag) => tag.label == 'unknown');
+    tags.remove(PerformanceTag.UNKNOWN);
     tags.sort((a, b) => b.elapsedMs - a.elapsedMs);
 
     // draw a pie chart
     String rowData =
         tags.map((tag) => "['${tag.label}', ${tag.elapsedMs}]").join(',');
     buf.writeln(
         '<div id="chart-div" style="width: 700px; height: 300px;"></div>');
     buf.writeln('''
       <script type="text/javascript">
         google.charts.load('current', {'packages':['corechart']});
@@ skipping 17 matching lines @@
     p('Total measured time: ${printMilliseconds(totalTime)}');
 
     // write out a table
     void _writeRow(List<String> data, {bool header: false}) {
       buf.write('<tr>');
       if (header) {
         for (String d in data) {
           buf.write('<th>$d</th>');
         }
       } else {
-        for (String d in data) {
-          buf.write('<td>$d</td>');
+        buf.write('<td>${data[0]}</td>');
+
+        for (String d in data.sublist(1)) {
+          buf.write('<td class="right">$d</td>');
         }
       }
       buf.writeln('</tr>');
     }
 
     buf.write('<table>');
     _writeRow(['Tag name', 'Time (in ms)', 'Percent'], header: true);
     void writeRow(PerformanceTag tag) {
       double percent = tag.elapsedMs / totalTime;
       _writeRow([
@@ skipping 119 matching lines @@
     addedFiles.sort();
     implicitFiles.sort();
 
     String lenCounter(List list) {
       return '<span class="counter" style="float: right;">${list.length}</span>';
     }
 
     h3('Context files');
 
     h4('Priority files ${lenCounter(priorityFiles)}', raw: true);
-    inputList(priorityFiles, (file) => buf.write(file));
+    ul(priorityFiles, (file) => buf.write(file), classes: 'scroll-table');
 
     h4('Added files ${lenCounter(addedFiles)}', raw: true);
-    inputList(addedFiles, (file) => buf.write(file));
+    ul(addedFiles, (file) => buf.write(file), classes: 'scroll-table');
 
     h4('ImplicitFiles files ${lenCounter(implicitFiles)}', raw: true);
-    inputList(implicitFiles, (file) => buf.write(file));
+    ul(implicitFiles, (file) => buf.write(file), classes: 'scroll-table');
 
     SourceFactory sourceFactory = driver.sourceFactory;
     if (sourceFactory is SourceFactoryImpl) {
       h3('Resolvers');
       for (UriResolver resolver in sourceFactory.resolvers) {
         h4(resolver.runtimeType.toString());
-        buf.write('<p>');
+        buf.write('<p class="scroll-table">');
         if (resolver is DartUriResolver) {
           DartSdk sdk = resolver.dartSdk;
           buf.write(' (sdk = ');
           buf.write(sdk.runtimeType);
           if (sdk is FolderBasedDartSdk) {
             buf.write(' (path = ');
             buf.write(sdk.directory.path);
             buf.write(')');
           } else if (sdk is EmbedderSdk) {
             buf.write(' (map = ');
@@ skipping 249 matching lines @@
     }
 
     buf.writeln('<div class="columns">');
 
     ServerPerformance perf = server.performanceAfterStartup;
     if (perf != null) {
       buf.writeln('<div class="column one-half">');
       h3('Current');
 
       int requestCount = perf.requestCount;
-      double averageLatency =
-          requestCount > 0 ? (perf.requestLatency / requestCount) : 0.0;
+      int averageLatency =
+          requestCount > 0 ? (perf.requestLatency / requestCount) : 0;

[Brian Wilkerson, 2017/05/31 13:50:50]

Did you want to use integer division (here and below)?

[devoncarew, 2017/05/31 14:14:30]

Yup, done.

       int maximumLatency = perf.maxLatency;
       double slowRequestPercent =
           requestCount > 0 ? (perf.slowRequestCount / requestCount) : 0.0;
 
       buf.write('<table>');
       writeRow([printInteger(requestCount), 'requests'],
           classes: ["right", null]);
       writeRow([printMilliseconds(averageLatency), 'average latency'],
           classes: ["right", null]);
       writeRow([printMilliseconds(maximumLatency), 'maximum latency'],
           classes: ["right", null]);
       writeRow([printPercentage(slowRequestPercent), '> 150 ms latency'],
           classes: ["right", null]);
       buf.write('</table>');
+
+      String time = server.uptime.toString();
+      if (time.contains('.')) {
+        time = time.substring(0, time.indexOf('.'));
+      }
+      buf.writeln(writeOption('Uptime', time));
+
       buf.write('</div>');
     }
 
     buf.writeln('<div class="column one-half">');
     h3('Startup');
     perf = server.performanceDuringStartup;
 
     int requestCount = perf.requestCount;
-    double averageLatency =
-        requestCount > 0 ? (perf.requestLatency / requestCount) : 0.0;
+    int averageLatency =
+        requestCount > 0 ? (perf.requestLatency / requestCount) : 0;
     int maximumLatency = perf.maxLatency;
     double slowRequestPercent =
         requestCount > 0 ? (perf.slowRequestCount / requestCount) : 0.0;
 
     buf.write('<table>');
     writeRow([printInteger(requestCount), 'requests'],
         classes: ["right", null]);
     writeRow([printMilliseconds(averageLatency), 'average latency'],
         classes: ["right", null]);
     writeRow([printMilliseconds(maximumLatency), 'maximum latency'],
         classes: ["right", null]);
     writeRow([printPercentage(slowRequestPercent), '> 150 ms latency'],
         classes: ["right", null]);
     buf.write('</table>');
 
     if (server.performanceAfterStartup != null) {
       int startupTime =
           server.performanceAfterStartup.startTime - perf.startTime;
-      p('(initial analysis time: ${printMilliseconds(startupTime)})');
+      buf.writeln(
+          writeOption('Initial analysis time', printMilliseconds(startupTime)));
     }
     buf.write('</div>');
 
     buf.write('</div>');
   }
 }
 
 String writeOption(String name, dynamic value) {
   return '$name: <code>$value</code><br> ';
 }
 
 String get _sdkVersion {
   String version = Platform.version;
   if (version.contains(' ')) {
     version = version.substring(0, version.indexOf(' '));
   }
   return version;
 }