Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 2918503002: Revert "Prefer single CID test for 'is' operator" (Closed)

Created:
3 years, 6 months ago by erikcorry
Modified:
3 years, 6 months ago
Reviewers:
kustermann
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Prefer single CID test for 'is' operator" This reverts commit 56e93fa2b0e1256addfe396858c572c216f28ab5 due to a failure in Flutter on Fuchsia - see bug MZRT-84 Revert of https://codereview.chromium.org/2899283002 R=kustermann@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/ac470292b0d12997962addf215cfdbc5a3c0df3a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -15 lines) Patch
M runtime/vm/jit_optimizer.cc View 2 chunks +14 lines, -15 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
erikcorry
3 years, 6 months ago (2017-05-31 09:26:55 UTC) #1
kustermann
lgtm
3 years, 6 months ago (2017-05-31 11:02:25 UTC) #2
erikcorry
3 years, 6 months ago (2017-05-31 11:05:49 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ac470292b0d12997962addf215cfdbc5a3c0df3a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698