Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Unified Diff: ui/arc/notification/arc_notification_content_view.cc

Issue 2918483002: Add an accessibility description for notification (Closed)
Patch Set: Fixed build failure Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/arc/notification/arc_notification_content_view.cc
diff --git a/ui/arc/notification/arc_notification_content_view.cc b/ui/arc/notification/arc_notification_content_view.cc
index 312dcb97f903e63d66ce622d45743429f8169721..0ad970196c7c0cdf588169152c68783dd4da9f16 100644
--- a/ui/arc/notification/arc_notification_content_view.cc
+++ b/ui/arc/notification/arc_notification_content_view.cc
@@ -637,7 +637,7 @@ bool ArcNotificationContentView::HandleAccessibleAction(
void ArcNotificationContentView::GetAccessibleNodeData(
ui::AXNodeData* node_data) {
- node_data->role = ui::AX_ROLE_BUTTON;
David Tseng 2017/06/02 17:56:11 I would keep this.
yoshiki 2017/06/05 05:06:03 Thank you for comment. if you don't think this cha
David Tseng 2017/06/05 16:27:17 No problem. It's is needed...see the other comment
+ node_data->role = ui::AX_ROLE_NOTIFICATION;
David Tseng 2017/06/02 17:56:11 And add this as role description string attribute.
David Tseng 2017/06/05 16:27:17 A role is a programmatic identifier (string) that
node_data->SetName(accessible_name_);
}

Powered by Google App Engine
This is Rietveld 408576698