Add an accessibility description for notification

ui/arc/notification/arc_notification_content_view.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/arc/notification/arc_notification_content_view.h"
 
 #include "ash/wm/window_util.h"
 #include "base/auto_reset.h"
 #include "base/memory/ptr_util.h"
 #include "components/exo/notification_surface.h"
@@ skipping 619 matching lines @@
     const ui::AXActionData& action_data) {
   if (item_ && action_data.action == ui::AX_ACTION_DO_DEFAULT) {
     item_->ToggleExpansion();
     return true;
   }
   return false;
 }
 
 void ArcNotificationContentView::GetAccessibleNodeData(
     ui::AXNodeData* node_data) {
-  node_data->role = ui::AX_ROLE_BUTTON;

[David Tseng, 2017/06/02 17:56:11]

I would keep this.

[yoshiki, 2017/06/05 05:06:03]

Thank you for comment. if you don't think this change is necessary, I don't do.

[David Tseng, 2017/06/05 16:27:17]

No problem. It's is needed...see the other comment.

+  node_data->role = ui::AX_ROLE_NOTIFICATION;

[David Tseng, 2017/06/02 17:56:11]

And add this as role description string attribute.

[David Tseng, 2017/06/05 16:27:17]

A role is a programmatic identifier (string) that describes the essential usage
of the widget e.g. button, checkbox, etc. A role description is a localized
string describing the widget's role e.g. push button, dial, etc.

My suggestion was simply to add this string as a role description.

To add a new role, you would have to make ChromeVox aware of that role or re-use
an existing role.

Your change prompted me to hook up support for role descriptions in ChromeVox
(which was missed whenever it was added in Blink).

   node_data->SetName(accessible_name_);
 }
 
 void ArcNotificationContentView::ButtonPressed(views::Button* sender,
                                                const ui::Event& event) {
   if (item_ && !item_->GetPinned() && sender == close_button_.get()) {
     CHECK_EQ(ArcNotificationView::kViewClassName, parent()->GetClassName());
     static_cast<ArcNotificationView*>(parent())->OnCloseButtonPressed();
   }
   if (item_ && settings_button_ && sender == settings_button_) {
@@ skipping 75 matching lines @@
     }
     if (close_button_) {
       close_button_->set_background(
           views::Background::CreateSolidBackground(current_color));
       close_button_->SchedulePaint();
     }
   }
 }
 
 }  // namespace arc