Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2918473002: Log build information from exparchive (Closed)

Created:
3 years, 6 months ago by mcgreevy
Modified:
3 years, 6 months ago
Reviewers:
mithro
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -6 lines) Patch
M client/cmd/isolate/exp_archive.go View 4 chunks +32 lines, -6 lines 2 comments Download

Messages

Total messages: 10 (4 generated)
mcgreevy
3 years, 6 months ago (2017-05-31 05:01:51 UTC) #2
mithro
LGTM with one comment. https://codereview.chromium.org/2918473002/diff/1/client/cmd/isolate/exp_archive.go File client/cmd/isolate/exp_archive.go (right): https://codereview.chromium.org/2918473002/diff/1/client/cmd/isolate/exp_archive.go#newcode346 client/cmd/isolate/exp_archive.go:346: type buildbotInfo struct { I ...
3 years, 6 months ago (2017-05-31 05:56:28 UTC) #3
mcgreevy
https://codereview.chromium.org/2918473002/diff/1/client/cmd/isolate/exp_archive.go File client/cmd/isolate/exp_archive.go (right): https://codereview.chromium.org/2918473002/diff/1/client/cmd/isolate/exp_archive.go#newcode346 client/cmd/isolate/exp_archive.go:346: type buildbotInfo struct { On 2017/05/31 05:56:28, mithro wrote: ...
3 years, 6 months ago (2017-05-31 06:09:24 UTC) #4
mithro
On 2017/05/31 06:09:24, mcgreevy wrote: > https://codereview.chromium.org/2918473002/diff/1/client/cmd/isolate/exp_archive.go > File client/cmd/isolate/exp_archive.go (right): > > https://codereview.chromium.org/2918473002/diff/1/client/cmd/isolate/exp_archive.go#newcode346 > ...
3 years, 6 months ago (2017-05-31 06:18:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2918473002/1
3 years, 6 months ago (2017-05-31 06:19:35 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 06:25:09 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/e6b32875ab0fafb2427a92412750a3071be3fc60

Powered by Google App Engine
This is Rietveld 408576698