Log build information from exparchive

Log build information from exparchive

BUG=727985
Review-Url: https://codereview.chromium.org/2918473002
Committed: https://github.com/luci/luci-go/commit/e6b32875ab0fafb2427a92412750a3071be3fc60

[mcgreevy, 2017-05-31 05:01:51]

mcgreevy@chromium.org changed reviewers:
+ tansell@chromium.org

[mithro, 2017-05-31 05:56:28]

LGTM with one comment.

https://codereview.chromium.org/2918473002/diff/1/client/cmd/isolate/exp_arch...
File client/cmd/isolate/exp_archive.go (right):

https://codereview.chromium.org/2918473002/diff/1/client/cmd/isolate/exp_arch...
client/cmd/isolate/exp_archive.go:346: type buildbotInfo struct {
I think you want to reuse this function in the other archive commands too so it
probably should be in a different file?

[mcgreevy, 2017-05-31 06:09:24]

https://codereview.chromium.org/2918473002/diff/1/client/cmd/isolate/exp_arch...
File client/cmd/isolate/exp_archive.go (right):

https://codereview.chromium.org/2918473002/diff/1/client/cmd/isolate/exp_arch...
client/cmd/isolate/exp_archive.go:346: type buildbotInfo struct {
On 2017/05/31 05:56:28, mithro wrote:
> I think you want to reuse this function in the other archive commands too so
it
> probably should be in a different file?

Yep, I have a followup CL almost done, where I'm adding logging to the legacy
archive. I've done some refactoring in that CL, which includes moving this into
its own file.  If you're OK with it, I'll leave this CL as-is and continue doing
the move in the other CL.

[mithro, 2017-05-31 06:18:46]

On 2017/05/31 06:09:24, mcgreevy wrote:
>
https://codereview.chromium.org/2918473002/diff/1/client/cmd/isolate/exp_arch...
> File client/cmd/isolate/exp_archive.go (right):
> 
>
https://codereview.chromium.org/2918473002/diff/1/client/cmd/isolate/exp_arch...
> client/cmd/isolate/exp_archive.go:346: type buildbotInfo struct {
> On 2017/05/31 05:56:28, mithro wrote:
> > I think you want to reuse this function in the other archive commands too so
> it
> > probably should be in a different file?
> 
> Yep, I have a followup CL almost done, where I'm adding logging to the legacy
> archive. I've done some refactoring in that CL, which includes moving this
into
> its own file.  If you're OK with it, I'll leave this CL as-is and continue
doing
> the move in the other CL.

Sure.

[mcgreevy, 2017-05-31 06:19:27]

The CQ bit was checked by mcgreevy@chromium.org

[commit-bot: I haz the power, 2017-05-31 06:19:35]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 06:25:06]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1496211567335970, "parent_rev":
"2f1325e5866c54ba3f1a9684cd59cba0ed5c5167", "commit_rev":
"e6b32875ab0fafb2427a92412750a3071be3fc60"}

[commit-bot: I haz the power, 2017-05-31 06:25:08]

Description was changed from

==========
Log build information from exparchive

BUG=727985
==========

to

==========
Log build information from exparchive

BUG=727985

Review-Url: https://codereview.chromium.org/2918473002
Committed:
https://github.com/luci/luci-go/commit/e6b32875ab0fafb2427a92412750a3071be3fc60
==========

[commit-bot: I haz the power, 2017-05-31 06:25:09]

Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/e6b32875ab0fafb2427a92412750a3071be3fc60