Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: ui/aura/window.cc

Issue 291843012: compositor: Tick the UI animations from cc, instead of from timer callbacks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/web_contents/aura/window_slider_unittest.cc ('k') | ui/aura/window_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/aura/window.cc
diff --git a/ui/aura/window.cc b/ui/aura/window.cc
index b1e95c3f4739743c33a2f1858dcb716746dde5ce..000f4d2d2f160a1e3d6cf873fc1b7c1d9e4bef04 100644
--- a/ui/aura/window.cc
+++ b/ui/aura/window.cc
@@ -217,8 +217,10 @@ Window::Window(WindowDelegate* delegate)
Window::~Window() {
// |layer()| can be NULL during tests, or if this Window is layerless.
- if (layer())
+ if (layer()) {
+ layer()->CompleteAllAnimations();
ajuma 2014/06/04 16:40:12 I think we have cases where animations are expecte
ajuma 2014/06/04 17:13:12 Sorry, that should be http://crbug.com/341862.
sadrul 2014/06/04 17:39:13 For animating a window closing, we usually clone t
ajuma 2014/06/04 19:14:42 Ah, things may have changed since the last time I
sky 2014/06/04 23:32:45 I think you only want to do this if layer()->owner
sadrul 2014/06/05 01:03:36 Done.
layer()->SuppressPaint();
+ }
// Let the delegate know we're in the processing of destroying.
if (delegate_)
« no previous file with comments | « content/browser/web_contents/aura/window_slider_unittest.cc ('k') | ui/aura/window_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698