Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2918413002: ARC: Add BootType parameter to ReportBootProgress() in metrics.mojom (Closed)

Created:
3 years, 6 months ago by Yusuke Sato
Modified:
3 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

ARC: Add BootType parameter to ReportBootProgress() in metrics.mojom ARC has 3 different boot mode. Previously, ARC boot time was recorded with the same UMA metric like Arc.AndroidBootTime regardless of the boot mode. This CL allows Chrome to use a dedicated UMA metric for each boot mode. This is better because a typical boot time is different for each boot mode. BUG=726346 TEST=tested with opt-in, ota, and regular ARC boot Review-Url: https://codereview.chromium.org/2906503003 Cr-Original-Commit-Position: refs/heads/master@{#475184} Review-Url: https://codereview.chromium.org/2918413002 . Cr-Commit-Position: refs/branch-heads/3112@{#162} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/ac00b8e7bda9ddd4b081d30d92104f48b62662f8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -25 lines) Patch
M components/arc/common/metrics.mojom View 2 chunks +20 lines, -1 line 0 comments Download
M components/arc/metrics/arc_metrics_service.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/arc/metrics/arc_metrics_service.cc View 3 chunks +45 lines, -22 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Yusuke Sato
3 years, 6 months ago (2017-06-05 18:36:38 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ac00b8e7bda9ddd4b081d30d92104f48b62662f8.

Powered by Google App Engine
This is Rietveld 408576698