CrOS Tablet Window management - Split Screen part I

ash/wm/overview/window_selector_item.h

Index: ash/wm/overview/window_selector_item.h
diff --git a/ash/wm/overview/window_selector_item.h b/ash/wm/overview/window_selector_item.h
index 6e77d73f8beff17812b244910bc405040c72af2f..a8b6a662ab42e809181286e27ce690304823e0f1 100644
--- a/ash/wm/overview/window_selector_item.h
+++ b/ash/wm/overview/window_selector_item.h
@@ -120,6 +120,11 @@ class ASH_EXPORT WindowSelectorItem : public views::ButtonListener,
   void OnWindowDestroying(aura::Window* window) override;
   void OnWindowTitleChanged(aura::Window* window) override;
 
+  // Handle the mouse/gesture event on the window selector item.

[varkha, 2017/06/21 01:51:53]

nit: How about "// Handle mouse/gesture events and facilitate dragging the
item." ?

[xdai1, 2017/06/22 21:46:34]

Done.

+  void HandlePressEvent(const gfx::Point& location_in_screen);
+  void HandleReleaseEvent(const gfx::Point& location_in_screen);
+  void HandleDragEvent(const gfx::Point& location_in_screen);
+
  private:
   class CaptionContainerView;
   class RoundedContainerView;
@@ -166,6 +171,14 @@ class ASH_EXPORT WindowSelectorItem : public views::ButtonListener,
 
   aura::Window* GetOverviewWindowForMinimizedStateForTest();
 
+  // Called before dragging. Scale up the window a little bit to indicate its

[varkha, 2017/06/21 01:51:53]

nit: Scale -> Scales

[xdai1, 2017/06/22 21:46:34]

Done.

+  // selection and stack the window at the top of the Z order in order to keep
+  // it visible while dragging around.
+  void PrepareDrag();

[varkha, 2017/06/21 01:51:54]

How about StartDrag() for symmetry?

[xdai1, 2017/06/22 21:46:34]

Done.

+
+  // Called after dragging. Stack the window at the bottom of the Z order.

[varkha, 2017/06/21 01:51:54]

nit: Stack -> Stacks.

[xdai1, 2017/06/22 21:46:34]

Done.

+  void EndDrag();
+
   // True if the item is being shown in the overview, false if it's being
   // filtered.
   bool dimmed_;