CrOS Tablet Window management - Split Screen part I

ash/wm/overview/window_selector_item.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_WM_OVERVIEW_WINDOW_SELECTOR_ITEM_H_
 #define ASH_WM_OVERVIEW_WINDOW_SELECTOR_ITEM_H_
 
 #include <memory>
 
 #include "ash/ash_export.h"
@@ skipping 102 matching lines @@
 
   const gfx::Rect& target_bounds() const { return target_bounds_; }
 
   // views::ButtonListener:
   void ButtonPressed(views::Button* sender, const ui::Event& event) override;
 
   // aura::WindowObserver:
   void OnWindowDestroying(aura::Window* window) override;
   void OnWindowTitleChanged(aura::Window* window) override;
 
+  // Handle the mouse/gesture event on the window selector item.

[varkha, 2017/06/21 01:51:53]

nit: How about "// Handle mouse/gesture events and facilitate dragging the
item." ?

[xdai1, 2017/06/22 21:46:34]

Done.

+  void HandlePressEvent(const gfx::Point& location_in_screen);
+  void HandleReleaseEvent(const gfx::Point& location_in_screen);
+  void HandleDragEvent(const gfx::Point& location_in_screen);
+
  private:
   class CaptionContainerView;
   class RoundedContainerView;
   friend class WindowSelectorTest;
 
   enum class HeaderFadeInMode {
     ENTER,
     UPDATE,
     EXIT,
   };
@@ skipping 26 matching lines @@
   void UpdateAccessibilityName();
 
   // Fades out a window caption when exiting overview mode.
   void FadeOut(std::unique_ptr<views::Widget> widget);
 
   // Allows a test to directly set animation state.
   gfx::SlideAnimation* GetBackgroundViewAnimation();
 
   aura::Window* GetOverviewWindowForMinimizedStateForTest();
 
+  // Called before dragging. Scale up the window a little bit to indicate its

[varkha, 2017/06/21 01:51:53]

nit: Scale -> Scales

[xdai1, 2017/06/22 21:46:34]

Done.

+  // selection and stack the window at the top of the Z order in order to keep
+  // it visible while dragging around.
+  void PrepareDrag();

[varkha, 2017/06/21 01:51:54]

How about StartDrag() for symmetry?

[xdai1, 2017/06/22 21:46:34]

Done.

+
+  // Called after dragging. Stack the window at the bottom of the Z order.

[varkha, 2017/06/21 01:51:54]

nit: Stack -> Stacks.

[xdai1, 2017/06/22 21:46:34]

Done.

+  void EndDrag();
+
   // True if the item is being shown in the overview, false if it's being
   // filtered.
   bool dimmed_;
 
   // The root window this item is being displayed on.
   aura::Window* root_window_;
 
   // The contained Window's wrapper.
   ScopedTransformOverviewWindow transform_window_;
 
@@ skipping 35 matching lines @@
   // corners. This view can have its color and opacity animated. It has a layer
   // which is the only textured layer used by the |item_widget_|.
   RoundedContainerView* background_view_;
 
   DISALLOW_COPY_AND_ASSIGN(WindowSelectorItem);
 };
 
 }  // namespace ash
 
 #endif  // ASH_WM_OVERVIEW_WINDOW_SELECTOR_ITEM_H_