[Reland] desktop_aura: do not restore focused view if it has modal transient child

[Reland] desktop_aura: do not restore focused view if it has modal transient child

Reland changes:
Disable the test coverage on OS_WIN for now, so that further
investigation can be done separately.

Changes:
RestoreFocusedView on DesktopNativeWidgetAura::HandleActivationChanged is added to process Linux desktop native widget asynchronous activation. This works when all the child widgets are managed by top level's FocusManager. However, this is not true for modal transient child, whose FocusManager is not the same as top level's FocusManager. In this case on activation, we shall not restore focused view on top level's FocusManager. Instead, the modal transient child window will get activated and restore focused view through its own NativeWidgetAura::OnWindowActivated.

BUG=727641
TEST=emulator test saw bug fixed and added test coverage

Review-Url: https://codereview.chromium.org/2919973002
Cr-Commit-Position: refs/heads/master@{#476835}
Committed: https://chromium.googlesource.com/chromium/src/+/81ead2ab2380d5f624b9ce63df050a76de134f06

patch from issue 2919973002 at patchset 40001 (http://crrev.com/2919973002#ps40001)

Review-Url: https://codereview.chromium.org/2918343003
Cr-Commit-Position: refs/heads/master@{#477087}
Committed: https://chromium.googlesource.com/chromium/src/+/ce9f58e951b6b5328e5517d425a2a76350cfd2cf

[Qiang(Joe) Xu, 2017-06-05 19:43:53]

The CQ bit was checked by warx@chromium.org to run a CQ dry run

[Qiang(Joe) Xu, 2017-06-05 19:44:03]

Description was changed from

==========
[Reland] desktop_aura: do not restore focused view if it has modal transient
child

Reland changes:
Disable the test coverage on OS_WIN for now, so that further
investigation can be done separately.

Changes:
RestoreFocusedView on DesktopNativeWidgetAura::HandleActivationChanged is added
to process Linux desktop native widget asynchronous activation. This works when
all the child widgets are managed by top level's FocusManager. However, this is
not true for modal transient child, whose FocusManager is not the same as top
level's FocusManager. In this case on activation, we shall not restore focused
view on top level's FocusManager. Instead, the modal transient child window will
get activated and restore focused view through its own
NativeWidgetAura::OnWindowActivated.

BUG=727641
TEST=emulator test saw bug fixed and added test coverage

Review-Url: https://codereview.chromium.org/2919973002
Cr-Commit-Position: refs/heads/master@{#476835}
Committed:
https://chromium.googlesource.com/chromium/src/+/81ead2ab2380d5f624b9ce63df05...

patch from issue 2919973002 at patchset 40001
(http://crrev.com/2919973002#ps40001)
==========

to

==========
[Reland] desktop_aura: do not restore focused view if it has modal transient
child

Reland changes:
Disable the test coverage on OS_WIN for now, so that further
investigation can be done separately.

Changes:
RestoreFocusedView on DesktopNativeWidgetAura::HandleActivationChanged is added
to process Linux desktop native widget asynchronous activation. This works when
all the child widgets are managed by top level's FocusManager. However, this is
not true for modal transient child, whose FocusManager is not the same as top
level's FocusManager. In this case on activation, we shall not restore focused
view on top level's FocusManager. Instead, the modal transient child window will
get activated and restore focused view through its own
NativeWidgetAura::OnWindowActivated.

BUG=727641
TEST=emulator test saw bug fixed and added test coverage

Review-Url: https://codereview.chromium.org/2919973002
Cr-Commit-Position: refs/heads/master@{#476835}
Committed:
https://chromium.googlesource.com/chromium/src/+/81ead2ab2380d5f624b9ce63df05...

patch from issue 2919973002 at patchset 40001
(http://crrev.com/2919973002#ps40001)
==========

[Qiang(Joe) Xu, 2017-06-05 19:44:03]

warx@chromium.org changed reviewers:
+ sky@chromium.org

[commit-bot: I haz the power, 2017-06-05 19:44:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Qiang(Joe) Xu, 2017-06-05 19:45:43]

Hi sky@, PTAL

The flakiness is not locally reproducible. I decided to disable the test for
now. So that further investigation will not make the production code reverted.

[commit-bot: I haz the power, 2017-06-05 21:11:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-05 21:11:59]

Dry run: This issue passed the CQ dry run.

[sky, 2017-06-05 21:13:57]

LGTM

[Qiang(Joe) Xu, 2017-06-05 21:15:34]

The CQ bit was checked by warx@chromium.org

[commit-bot: I haz the power, 2017-06-05 21:16:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-05 21:22:55]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496697334357120,
"parent_rev": "45db465b6f0187a7c98414bfacdbd9bc4c9ce334", "commit_rev":
"ce9f58e951b6b5328e5517d425a2a76350cfd2cf"}

[commit-bot: I haz the power, 2017-06-05 21:23:08]

Description was changed from

==========
[Reland] desktop_aura: do not restore focused view if it has modal transient
child

Reland changes:
Disable the test coverage on OS_WIN for now, so that further
investigation can be done separately.

Changes:
RestoreFocusedView on DesktopNativeWidgetAura::HandleActivationChanged is added
to process Linux desktop native widget asynchronous activation. This works when
all the child widgets are managed by top level's FocusManager. However, this is
not true for modal transient child, whose FocusManager is not the same as top
level's FocusManager. In this case on activation, we shall not restore focused
view on top level's FocusManager. Instead, the modal transient child window will
get activated and restore focused view through its own
NativeWidgetAura::OnWindowActivated.

BUG=727641
TEST=emulator test saw bug fixed and added test coverage

Review-Url: https://codereview.chromium.org/2919973002
Cr-Commit-Position: refs/heads/master@{#476835}
Committed:
https://chromium.googlesource.com/chromium/src/+/81ead2ab2380d5f624b9ce63df05...

patch from issue 2919973002 at patchset 40001
(http://crrev.com/2919973002#ps40001)
==========

to

==========
[Reland] desktop_aura: do not restore focused view if it has modal transient
child

Reland changes:
Disable the test coverage on OS_WIN for now, so that further
investigation can be done separately.

Changes:
RestoreFocusedView on DesktopNativeWidgetAura::HandleActivationChanged is added
to process Linux desktop native widget asynchronous activation. This works when
all the child widgets are managed by top level's FocusManager. However, this is
not true for modal transient child, whose FocusManager is not the same as top
level's FocusManager. In this case on activation, we shall not restore focused
view on top level's FocusManager. Instead, the modal transient child window will
get activated and restore focused view through its own
NativeWidgetAura::OnWindowActivated.

BUG=727641
TEST=emulator test saw bug fixed and added test coverage

Review-Url: https://codereview.chromium.org/2919973002
Cr-Commit-Position: refs/heads/master@{#476835}
Committed:
https://chromium.googlesource.com/chromium/src/+/81ead2ab2380d5f624b9ce63df05...

patch from issue 2919973002 at patchset 40001
(http://crrev.com/2919973002#ps40001)

Review-Url: https://codereview.chromium.org/2918343003
Cr-Commit-Position: refs/heads/master@{#477087}
Committed:
https://chromium.googlesource.com/chromium/src/+/ce9f58e951b6b5328e5517d425a2...
==========

[commit-bot: I haz the power, 2017-06-05 21:23:13]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ce9f58e951b6b5328e5517d425a2...