Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 2918283002: Added null safety to CSSParserContext args in CSSPropertyOffsetPathUtils (Closed)

Created:
3 years, 6 months ago by Bugs Nash
Modified:
3 years, 6 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Added null safety to CSSParserContext args in CSSPropertyOffsetPathUtils Changed CSSParserContext argument from * to & for null safety and readability. BUG=668012 Review-Url: https://codereview.chromium.org/2918283002 Cr-Commit-Position: refs/heads/master@{#477597} Committed: https://chromium.googlesource.com/chromium/src/+/1f3b0bc4573600a0a9622146949f0e4b0c2209f0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/properties/CSSPropertyAPIOffsetPath.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/properties/CSSPropertyOffsetPathUtils.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/properties/CSSPropertyOffsetPathUtils.cpp View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Bugs Nash
3 years, 6 months ago (2017-06-05 03:18:15 UTC) #4
shend
lgtm
3 years, 6 months ago (2017-06-05 04:17:53 UTC) #5
Bugs Nash
+alancutter for owners
3 years, 6 months ago (2017-06-05 04:20:48 UTC) #7
alancutter (OOO until 2018)
lgtm
3 years, 6 months ago (2017-06-07 05:07:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2918283002/1
3 years, 6 months ago (2017-06-07 07:35:37 UTC) #12
commit-bot: I haz the power
3 years, 6 months ago (2017-06-07 09:34:37 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1f3b0bc4573600a0a9622146949f...

Powered by Google App Engine
This is Rietveld 408576698