Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 2918173002: Revert of [translate] Defer start of translate ranker model load to first use. (Closed)

Created:
3 years, 6 months ago by hamelphi
Modified:
3 years, 6 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [translate] Defer start of translate ranker model load to first use. (patchset #2 id:40001 of https://codereview.chromium.org/2871843003/ ) Reason for revert: The perf regression was not caused by this piece of code. Reverting to the original behavior. See https://docs.google.com/document/d/1eeTSJg18rJ4v_oxxSJU8MK20UywnEhocWk_WrWv8kQE/edit for details of the regression investigation. Original issue's description: > [translate] Defer start of translate ranker model load to first use. > > This CL is in response to perf regression (see referenced bugs). > > BUG=697947, 697665 > > Review-Url: https://codereview.chromium.org/2871843003 > Cr-Commit-Position: refs/heads/master@{#471086} > Committed: https://chromium.googlesource.com/chromium/src/+/d2876f4ee1c1a01ee262ca55752503ba3a30a6d5 TBR=benhenry@chromium.org,vmiura@chromium.org,sullivan@chromium.org,tdresser@chromium.org,groby@chromium.org,rogerm@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=697947, 697665 Review-Url: https://codereview.chromium.org/2918173002 Cr-Commit-Position: refs/heads/master@{#478379} Committed: https://chromium.googlesource.com/chromium/src/+/cd4a0934f93239d0791e80d7a5da5b81eea368d9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M components/translate/core/browser/translate_ranker_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (14 generated)
hamelphi
Created Revert of [translate] Defer start of translate ranker model load to first use.
3 years, 6 months ago (2017-06-02 19:37:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2918173002/1
3 years, 6 months ago (2017-06-02 19:38:07 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 6 months ago (2017-06-02 19:38:08 UTC) #5
hamelphi
3 years, 6 months ago (2017-06-02 19:38:47 UTC) #6
hamelphi
Removing extra reviewers
3 years, 6 months ago (2017-06-05 15:53:43 UTC) #16
Roger McFarlane (Chromium)
lgtm
3 years, 6 months ago (2017-06-06 19:28:59 UTC) #17
groby-ooo-7-16
RS LGTM
3 years, 6 months ago (2017-06-07 16:27:51 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2918173002/1
3 years, 6 months ago (2017-06-09 18:41:52 UTC) #20
commit-bot: I haz the power
3 years, 6 months ago (2017-06-09 19:45:33 UTC) #23
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cd4a0934f93239d0791e80d7a5da...

Powered by Google App Engine
This is Rietveld 408576698