cc: Workaround invalid property tree state on Layers.

cc: Workaround invalid property tree state on Layers.

The impl thread is somehow getting Layers with invalid property tree
indices which cause crashes during UpdateDrawProperties. Don't add them
to the visible layer list to keep from crashing later in the stack.

BUG=728511, 727209, 726423
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2918163002
Cr-Commit-Position: refs/heads/master@{#476811}
Committed: https://chromium.googlesource.com/chromium/src/+/5867068aa6d1677d3ff8a9da36ba793757b171aa

[Khushal, 2017-06-02 18:28:18]

Description was changed from

==========
cc: Workaround invalid property tree state on Layers.

The impl thread is somehow getting Layers with invalid property tree
indices which cause crashes during UpdateDrawProperties. Don't add them
to the visible layer list to keep from crashing later in the stack.

BUG=728511, 727209, 726423
==========

to

==========
cc: Workaround invalid property tree state on Layers.

The impl thread is somehow getting Layers with invalid property tree
indices which cause crashes during UpdateDrawProperties. Don't add them
to the visible layer list to keep from crashing later in the stack.

BUG=728511, 727209, 726423
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Khushal, 2017-06-02 18:29:28]

khushalsagar@chromium.org changed reviewers:
+ enne@chromium.org

[Khushal, 2017-06-02 18:29:28]

PTAL.

[enne (OOO), 2017-06-02 18:41:19]

https://codereview.chromium.org/2918163002/diff/1/cc/layers/layer_impl.cc
File cc/layers/layer_impl.cc (right):

https://codereview.chromium.org/2918163002/diff/1/cc/layers/layer_impl.cc#new...
cc/layers/layer_impl.cc:989: bool LayerImpl::EnsureValidPropertyTreeIndices()
const {
I know there's a link to the bug at the callsite, but can you add a link to the
bug here too?

https://codereview.chromium.org/2918163002/diff/1/cc/layers/layer_impl.h
File cc/layers/layer_impl.h (right):

https://codereview.chromium.org/2918163002/diff/1/cc/layers/layer_impl.h#newc...
cc/layers/layer_impl.h:451: bool EnsureValidPropertyTreeIndices() const;
bikeshed: functions called "Ensure" I expect to be void, in that they are either
asserting or silently making something valid.  This const function seems more
like a "HasValidPropertyTreeIndices".

[Khushal, 2017-06-02 18:47:03]

https://codereview.chromium.org/2918163002/diff/1/cc/layers/layer_impl.cc
File cc/layers/layer_impl.cc (right):

https://codereview.chromium.org/2918163002/diff/1/cc/layers/layer_impl.cc#new...
cc/layers/layer_impl.cc:989: bool LayerImpl::EnsureValidPropertyTreeIndices()
const {
On 2017/06/02 18:41:19, enne wrote:
> I know there's a link to the bug at the callsite, but can you add a link to
the
> bug here too?

Sure. Done.

https://codereview.chromium.org/2918163002/diff/1/cc/layers/layer_impl.h
File cc/layers/layer_impl.h (right):

https://codereview.chromium.org/2918163002/diff/1/cc/layers/layer_impl.h#newc...
cc/layers/layer_impl.h:451: bool EnsureValidPropertyTreeIndices() const;
On 2017/06/02 18:41:19, enne wrote:
> bikeshed: functions called "Ensure" I expect to be void, in that they are
either
> asserting or silently making something valid.  This const function seems more
> like a "HasValidPropertyTreeIndices".

Done.

[enne (OOO), 2017-06-02 18:49:54]

lgtm

[Khushal, 2017-06-02 18:50:18]

The CQ bit was checked by khushalsagar@chromium.org

[commit-bot: I haz the power, 2017-06-02 18:51:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 19:36:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 19:36:21]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Khushal, 2017-06-02 20:18:05]

The CQ bit was checked by khushalsagar@chromium.org

[Khushal, 2017-06-02 20:18:05]

The patchset sent to the CQ was uploaded after l-g-t-m from enne@chromium.org
Link to the patchset: https://codereview.chromium.org/2918163002/#ps40001
(title: "..")

[commit-bot: I haz the power, 2017-06-02 20:18:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 22:11:06]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496434685428560,
"parent_rev": "b0a378fde6de7bd1e63db9b8249600f4ab4feaf9", "commit_rev":
"5867068aa6d1677d3ff8a9da36ba793757b171aa"}

[commit-bot: I haz the power, 2017-06-02 22:11:18]

Description was changed from

==========
cc: Workaround invalid property tree state on Layers.

The impl thread is somehow getting Layers with invalid property tree
indices which cause crashes during UpdateDrawProperties. Don't add them
to the visible layer list to keep from crashing later in the stack.

BUG=728511, 727209, 726423
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Workaround invalid property tree state on Layers.

The impl thread is somehow getting Layers with invalid property tree
indices which cause crashes during UpdateDrawProperties. Don't add them
to the visible layer list to keep from crashing later in the stack.

BUG=728511, 727209, 726423
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2918163002
Cr-Commit-Position: refs/heads/master@{#476811}
Committed:
https://chromium.googlesource.com/chromium/src/+/5867068aa6d1677d3ff8a9da36ba...
==========

[commit-bot: I haz the power, 2017-06-02 22:11:20]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5867068aa6d1677d3ff8a9da36ba...