Replace deprecated base::NonThreadSafe in /extensions/renderer/api/display_source in favor of Threa…

Replace deprecated base::NonThreadSafe in /extensions/renderer/api/display_source in favor of ThreadChecker.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c84.

(amend to use ThreadChecker instead of SequenceChecker to make this
CL a no-op and expedite it per being the very last one!)

If you're wondering why there's a second wave of this, the first version of the
script handled "NON_EXPORTED_BASE(public base::NonThreadSafe)" but not
"public NON_EXPORTED_BASE(base::NonThreadSafe)"...

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implicitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

TBR=alexander.shalamov@intel.com

Review-Url: https://codereview.chromium.org/2918113004
Cr-Commit-Position: refs/heads/master@{#476754}
Committed: https://chromium.googlesource.com/chromium/src/+/db0d68b9a8438d6d8480f5372f984c035dfdae57

[gab, 2017-06-02 18:04:34]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[gab, 2017-06-02 18:04:36]

Hi, this is an automated change made by https://crbug.com/676387#c84 and sharded
across directories for OWNERS.

No human has looked at this specific output yet, see cl description for things
to watch for.

If it LGTY, please CQ.

Thanks!
Gab

[commit-bot: I haz the power, 2017-06-02 18:04:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 18:18:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 18:18:30]

Dry run: This issue passed the CQ dry run.

[gab, 2017-06-02 19:18:18]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 19:18:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2017-06-02 19:19:00]

Description was changed from

==========
Replace deprecated base::NonThreadSafe in
/extensions/renderer/api/display_source in favor of SequenceChecker.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c84.

If you're wondering why there's a second wave of this, the first version of the
script handled "NON_EXPORTED_BASE(public base::NonThreadSafe)" but not
"public NON_EXPORTED_BASE(base::NonThreadSafe)"...

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implicitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=alexander.shalamov@intel.com
==========

to

==========
Replace deprecated base::NonThreadSafe in
/extensions/renderer/api/display_source in favor of ThreadChecker.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c84.

(amend to use ThreadChecker instead of SequenceChecker to make this
CL a no-op and expedite it per being the very last one!)

If you're wondering why there's a second wave of this, the first version of the
script handled "NON_EXPORTED_BASE(public base::NonThreadSafe)" but not
"public NON_EXPORTED_BASE(base::NonThreadSafe)"...

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implicitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=alexander.shalamov@intel.com
==========

[gab, 2017-06-02 19:20:37]

Opted to use ThreadChecker to make this CL a true no-op (and allows TBR per this
being the very last CL of its kind!). I invite you to consider using sequence
constructs rather than thread constructs in general going forward.

Thanks!
Gab

[gab, 2017-06-02 19:20:51]

Description was changed from

==========
Replace deprecated base::NonThreadSafe in
/extensions/renderer/api/display_source in favor of ThreadChecker.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c84.

(amend to use ThreadChecker instead of SequenceChecker to make this
CL a no-op and expedite it per being the very last one!)

If you're wondering why there's a second wave of this, the first version of the
script handled "NON_EXPORTED_BASE(public base::NonThreadSafe)" but not
"public NON_EXPORTED_BASE(base::NonThreadSafe)"...

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implicitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

R=alexander.shalamov@intel.com
==========

to

==========
Replace deprecated base::NonThreadSafe in
/extensions/renderer/api/display_source in favor of ThreadChecker.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c84.

(amend to use ThreadChecker instead of SequenceChecker to make this
CL a no-op and expedite it per being the very last one!)

If you're wondering why there's a second wave of this, the first version of the
script handled "NON_EXPORTED_BASE(public base::NonThreadSafe)" but not
"public NON_EXPORTED_BASE(base::NonThreadSafe)"...

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implicitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

TBR=alexander.shalamov@intel.com
==========

[gab, 2017-06-02 19:21:01]

On 2017/06/02 19:20:37, gab wrote:
> Opted to use ThreadChecker to make this CL a true no-op (and allows TBR per
this
> being the very last CL of its kind!). I invite you to consider using sequence
> constructs rather than thread constructs in general going forward.

TBR=alexander.shalamov@intel.com

> 
> Thanks!
> Gab

[gab, 2017-06-02 19:21:05]

The CQ bit was unchecked by gab@chromium.org

[gab, 2017-06-02 19:21:09]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2017-06-02 19:21:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 19:33:50]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496431269526830,
"parent_rev": "13fb844cea0b4c3a701c1bad00d3fce8fc2eb1b6", "commit_rev":
"db0d68b9a8438d6d8480f5372f984c035dfdae57"}

[commit-bot: I haz the power, 2017-06-02 19:33:58]

Description was changed from

==========
Replace deprecated base::NonThreadSafe in
/extensions/renderer/api/display_source in favor of ThreadChecker.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c84.

(amend to use ThreadChecker instead of SequenceChecker to make this
CL a no-op and expedite it per being the very last one!)

If you're wondering why there's a second wave of this, the first version of the
script handled "NON_EXPORTED_BASE(public base::NonThreadSafe)" but not
"public NON_EXPORTED_BASE(base::NonThreadSafe)"...

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implicitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

TBR=alexander.shalamov@intel.com
==========

to

==========
Replace deprecated base::NonThreadSafe in
/extensions/renderer/api/display_source in favor of ThreadChecker.

Note to crash team: This CL is a refactor and has no intended behavior change.

This change was scripted by https://crbug.com/676387#c84.

(amend to use ThreadChecker instead of SequenceChecker to make this
CL a no-op and expedite it per being the very last one!)

If you're wondering why there's a second wave of this, the first version of the
script handled "NON_EXPORTED_BASE(public base::NonThreadSafe)" but not
"public NON_EXPORTED_BASE(base::NonThreadSafe)"...

Note-worthy for the reviewer:
 * SequenceChecker enforces thread-safety but not thread-affinity!
   If the classes that were updated are thread-affine (use thread local
   storage or a third-party API that does) they should be migrated to
   ThreadChecker instead.
 * ~NonThreadSafe() used to implicitly check in its destructor
   ~Sequence/ThreadChecker() doesn't by design. To keep this CL a
   no-op, an explicit check was added to the destructor of migrated
   classes.
 * NonThreadSafe used to provide access to subclasses, as such
   the |sequence_checker_| member was made protected rather than
   private where necessary.

BUG=676387
This CL was uploaded by git cl split.

TBR=alexander.shalamov@intel.com

Review-Url: https://codereview.chromium.org/2918113004
Cr-Commit-Position: refs/heads/master@{#476754}
Committed:
https://chromium.googlesource.com/chromium/src/+/db0d68b9a8438d6d8480f5372f98...
==========

[commit-bot: I haz the power, 2017-06-02 19:33:59]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/db0d68b9a8438d6d8480f5372f98...